Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: ui/views/mus/desktop_window_tree_host_mus.cc

Issue 2655463009: aura-mus: Implement DesktopWindowTreeHostMus::StackAbove(). (Closed)
Patch Set: Add comment. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/aura/test/mus/test_window_tree.cc ('k') | ui/views/mus/desktop_window_tree_host_mus_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/mus/desktop_window_tree_host_mus.cc
diff --git a/ui/views/mus/desktop_window_tree_host_mus.cc b/ui/views/mus/desktop_window_tree_host_mus.cc
index 9cff6ce99ca63f8bbdb57d97e12ceb2b82202b7f..02cf6376934d0bff1123c9b9149b382b160d6280 100644
--- a/ui/views/mus/desktop_window_tree_host_mus.cc
+++ b/ui/views/mus/desktop_window_tree_host_mus.cc
@@ -406,9 +406,12 @@ void DesktopWindowTreeHostMus::SetSize(const gfx::Size& size) {
SetBoundsInDIP(screen_bounds);
}
-void DesktopWindowTreeHostMus::StackAbove(aura::Window* window) {
- // TODO: implement window stacking, http://crbug.com/663617.
- NOTIMPLEMENTED();
+void DesktopWindowTreeHostMus::StackAbove(aura::Window* relative) {
+ // Windows and X11 check for |relative| being nullptr and fail silently. It
+ // also looks like |relative| is usually multiple children deep in the root
+ // window, which we must pass instead.
+ if (relative && relative->GetRootWindow())
+ WindowTreeHostMus::StackAbove(relative->GetRootWindow());
}
void DesktopWindowTreeHostMus::StackAtTop() {
« no previous file with comments | « ui/aura/test/mus/test_window_tree.cc ('k') | ui/views/mus/desktop_window_tree_host_mus_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698