Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 2655463002: Revert of Use a new Supplement constructor in Navigator supplements (part 2) (Closed)

Created:
3 years, 11 months ago by waffles
Modified:
3 years, 11 months ago
Reviewers:
haraken, sof
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, mlamouri+watch-blink_chromium.org, serviceworker-reviews, mvanouwerkerk+watch_chromium.org, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, shimazu+serviceworker_chromium.org, kinuko+fileapi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use a new Supplement constructor in Navigator supplements (part 2) (patchset #3 id:40001 of https://codereview.chromium.org/2649073002/ ) Reason for revert: Manual bisection shows that the following regressions occur starting at 560d55d7d: Regressions: Unexpected leaks (6) fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html [ Leak ] fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html [ Leak ] fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html [ Leak ] fast/dom/Window/property-access-on-cached-window-after-frame-navigated.html [ Leak ] fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced.html [ Leak ] fast/dom/Window/property-access-on-cached-window-after-frame-removed.html [ Leak ] The leaked object is {"numberOfLiveSuspendableObjects":[2,3]} Original issue's description: > Use a new Supplement constructor in Navigator supplements (part 2) > > This is a step to deprecate the default constructor of Supplement<>. > > BUG=610176 > > Review-Url: https://codereview.chromium.org/2649073002 > Cr-Commit-Position: refs/heads/master@{#445357} > Committed: https://chromium.googlesource.com/chromium/src/+/560d55d7d2122116b456e157f761eaa252246e4f TBR=sigbjornf@opera.com,haraken@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=610176 Review-Url: https://codereview.chromium.org/2655463002 Cr-Commit-Position: refs/heads/master@{#445415} Committed: https://chromium.googlesource.com/chromium/src/+/cf7b58737b355ece16d0511aa43c95d6d11d0445

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -31 lines) Patch
M third_party/WebKit/Source/modules/permissions/NavigatorPermissions.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/permissions/NavigatorPermissions.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/permissions/WorkerNavigatorPermissions.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/permissions/WorkerNavigatorPermissions.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/NavigatorPresentation.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/presentation/NavigatorPresentation.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/WorkerNavigatorStorageQuota.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/quota/WorkerNavigatorStorageQuota.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webauth/NavigatorAuth.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webshare/NavigatorShare.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/NavigatorUSB.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
waffles
Created Revert of Use a new Supplement constructor in Navigator supplements (part 2)
3 years, 11 months ago (2017-01-23 18:31:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655463002/1
3 years, 11 months ago (2017-01-23 18:32:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/cf7b58737b355ece16d0511aa43c95d6d11d0445
3 years, 11 months ago (2017-01-23 18:34:21 UTC) #6
haraken
3 years, 11 months ago (2017-01-23 23:47:24 UTC) #7
Message was sent while issue was closed.
Thanks, LGTM

Powered by Google App Engine
This is Rietveld 408576698