Chromium Code Reviews
DescriptionRevert of Use a new Supplement constructor in Navigator supplements (part 2) (patchset #3 id:40001 of https://codereview.chromium.org/2649073002/ )
Reason for revert:
Manual bisection shows that the following regressions occur starting at 560d55d7d:
Regressions: Unexpected leaks (6)
fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html [ Leak ]
fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html [ Leak ]
fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html [ Leak ]
fast/dom/Window/property-access-on-cached-window-after-frame-navigated.html [ Leak ]
fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced.html [ Leak ]
fast/dom/Window/property-access-on-cached-window-after-frame-removed.html [ Leak ]
The leaked object is {"numberOfLiveSuspendableObjects":[2,3]}
Original issue's description:
> Use a new Supplement constructor in Navigator supplements (part 2)
>
> This is a step to deprecate the default constructor of Supplement<>.
>
> BUG=610176
>
> Review-Url: https://codereview.chromium.org/2649073002
> Cr-Commit-Position: refs/heads/master@{#445357}
> Committed: https://chromium.googlesource.com/chromium/src/+/560d55d7d2122116b456e157f761eaa252246e4f
TBR=sigbjornf@opera.com,haraken@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=610176
Review-Url: https://codereview.chromium.org/2655463002
Cr-Commit-Position: refs/heads/master@{#445415}
Committed: https://chromium.googlesource.com/chromium/src/+/cf7b58737b355ece16d0511aa43c95d6d11d0445
Patch Set 1 #Messages
Total messages: 7 (3 generated)
|