Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2649073002: Use a new Supplement constructor in Navigator supplements (part 2) (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
sof
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, mlamouri+watch-blink_chromium.org, serviceworker-reviews, mvanouwerkerk+watch_chromium.org, nhiroki, haraken, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, shimazu+serviceworker_chromium.org, kinuko+fileapi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a new Supplement constructor in Navigator supplements (part 2) This is a step to deprecate the default constructor of Supplement<>. BUG=610176 Review-Url: https://codereview.chromium.org/2649073002 Cr-Commit-Position: refs/heads/master@{#445357} Committed: https://chromium.googlesource.com/chromium/src/+/560d55d7d2122116b456e157f761eaa252246e4f

Patch Set 1 #

Patch Set 2 : temp #

Total comments: 1

Patch Set 3 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -19 lines) Patch
M third_party/WebKit/Source/modules/permissions/NavigatorPermissions.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/permissions/NavigatorPermissions.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/permissions/WorkerNavigatorPermissions.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/permissions/WorkerNavigatorPermissions.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/NavigatorPresentation.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/presentation/NavigatorPresentation.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/WorkerNavigatorStorageQuota.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/quota/WorkerNavigatorStorageQuota.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webauth/NavigatorAuth.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webshare/NavigatorShare.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/NavigatorUSB.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
haraken
PTAL
3 years, 11 months ago (2017-01-23 08:09:13 UTC) #4
sof
lgtm https://codereview.chromium.org/2649073002/diff/20001/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp File third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp (right): https://codereview.chromium.org/2649073002/diff/20001/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp#newcode38 third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp:38: ContextLifecycleObserver(navigator.frame()->document()) {} Need a frame() null check here ...
3 years, 11 months ago (2017-01-23 08:19:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649073002/40001
3 years, 11 months ago (2017-01-23 08:52:41 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/352889)
3 years, 11 months ago (2017-01-23 10:10:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649073002/40001
3 years, 11 months ago (2017-01-23 11:04:40 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/560d55d7d2122116b456e157f761eaa252246e4f
3 years, 11 months ago (2017-01-23 11:47:59 UTC) #15
waffles
3 years, 11 months ago (2017-01-23 18:31:28 UTC) #16
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2655463002/ by waffles@chromium.org.

The reason for reverting is: Manual bisection shows that the following
regressions occur starting at 560d55d7d:

Regressions: Unexpected leaks (6)
 
fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html
[ Leak ]
 
fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html
[ Leak ]
  fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html
[ Leak ]
  fast/dom/Window/property-access-on-cached-window-after-frame-navigated.html [
Leak ]
 
fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced.html
[ Leak ]
  fast/dom/Window/property-access-on-cached-window-after-frame-removed.html [
Leak ]

The leaked object is {"numberOfLiveSuspendableObjects":[2,3]}.

Powered by Google App Engine
This is Rietveld 408576698