third_party/WebKit/Source/modules/permissions/NavigatorPermissions.cpp - Issue 2655463002: Revert of Use a new Supplement constructor in Navigator supplements (part 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/permissions/NavigatorPermissions.cpp

Issue 2655463002: Revert of Use a new Supplement constructor in Navigator supplements (part 2) (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/permissions/NavigatorPermissions.h ('k') | third_party/WebKit/Source/modules/permissions/WorkerNavigatorPermissions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/permissions/NavigatorPermissions.cpp

diff --git a/third_party/WebKit/Source/modules/permissions/NavigatorPermissions.cpp b/third_party/WebKit/Source/modules/permissions/NavigatorPermissions.cpp

index f76721c6ccb0930240adf0cfd5248faf336ad8e2..28b44ed97e61dd738995642132a4c371dabaf4a0 100644

--- a/third_party/WebKit/Source/modules/permissions/NavigatorPermissions.cpp

+++ b/third_party/WebKit/Source/modules/permissions/NavigatorPermissions.cpp

@@ -9,8 +9,7 @@

namespace blink {

-NavigatorPermissions::NavigatorPermissions(Navigator& navigator)

- : Supplement<Navigator>(navigator) {}

+NavigatorPermissions::NavigatorPermissions() {}

// static

const char* NavigatorPermissions::supplementName() {

@@ -22,7 +21,7 @@

NavigatorPermissions* supplement = static_cast<NavigatorPermissions*>(

Supplement<Navigator>::from(navigator, supplementName()));

if (!supplement) {

- supplement = new NavigatorPermissions(navigator);

+ supplement = new NavigatorPermissions();

provideTo(navigator, supplementName(), supplement);

}

return *supplement;