Chromium Code Reviews
DescriptionRevert of Destroy incognito profile from close all incognito notification. (patchset #1 id:1 of https://codereview.chromium.org/2653753008/ )
Reason for revert:
Breaks build:
../../chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java:84: error: method get in class BrowserStartupController cannot be applied to given types;
if (BrowserStartupController.get(LibraryProcessType.PROCESS_BROWSER)
^
required: Context,int
found: int
reason: actual and formal argument lists differ in length
https://uberchromegw.corp.google.com/i/official.android.continuous/builders/beta-arm/builds/6052
Original issue's description:
> Destroy incognito profile from close all incognito notification.
>
> Also destroy the incognito profile when starting up tabbed mode
> and there are no discoverable incognito tabs around.
>
> BUG=673489
>
> Review-Url: https://codereview.chromium.org/2649773007
> Cr-Original-Commit-Position: refs/heads/master@{#446140}
> Review-Url: https://codereview.chromium.org/2653753008 .
> Cr-Commit-Position: refs/branch-heads/2987@{#115}
> Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
> Committed: https://chromium.googlesource.com/chromium/src/+/29a4956a7ff9985a5e2b951d41b435d1b3d38b94
TBR=tedchoc@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=673489
Review-Url: https://codereview.chromium.org/2655383003
Cr-Commit-Position: refs/branch-heads/2987@{#146}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/61ef8268f9904aecb561105246c92d753ca53dda
Patch Set 1 #
Messages
Total messages: 14 (8 generated)
|
|||||||||||||||||||||||||||||||||||||