Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2655383003: Revert of Destroy incognito profile from close all incognito notification. (Closed)

Created:
3 years, 10 months ago by amineer
Modified:
3 years, 10 months ago
Reviewers:
Ted C
CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Revert of Destroy incognito profile from close all incognito notification. (patchset #1 id:1 of https://codereview.chromium.org/2653753008/ ) Reason for revert: Breaks build: ../../chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java:84: error: method get in class BrowserStartupController cannot be applied to given types; if (BrowserStartupController.get(LibraryProcessType.PROCESS_BROWSER) ^ required: Context,int found: int reason: actual and formal argument lists differ in length https://uberchromegw.corp.google.com/i/official.android.continuous/builders/beta-arm/builds/6052 Original issue's description: > Destroy incognito profile from close all incognito notification. > > Also destroy the incognito profile when starting up tabbed mode > and there are no discoverable incognito tabs around. > > BUG=673489 > > Review-Url: https://codereview.chromium.org/2649773007 > Cr-Original-Commit-Position: refs/heads/master@{#446140} > Review-Url: https://codereview.chromium.org/2653753008 . > Cr-Commit-Position: refs/branch-heads/2987@{#115} > Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} > Committed: https://chromium.googlesource.com/chromium/src/+/29a4956a7ff9985a5e2b951d41b435d1b3d38b94 TBR=tedchoc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=673489 Review-Url: https://codereview.chromium.org/2655383003 Cr-Commit-Position: refs/branch-heads/2987@{#146} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/61ef8268f9904aecb561105246c92d753ca53dda

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -85 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 5 chunks +1 line, -62 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java View 2 chunks +4 lines, -15 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/BrowserStartupController.java View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
amineer
Created Revert of Destroy incognito profile from close all incognito notification.
3 years, 10 months ago (2017-01-27 16:15:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655383003/1
3 years, 10 months ago (2017-01-27 16:15:33 UTC) #3
commit-bot: I haz the power
Failed to commit the patch.
3 years, 10 months ago (2017-01-27 16:27:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655383003/1
3 years, 10 months ago (2017-01-27 16:30:17 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/61ef8268f9904aecb561105246c92d753ca53dda
3 years, 10 months ago (2017-01-27 16:33:58 UTC) #13
Ted C
3 years, 10 months ago (2017-01-27 16:41:50 UTC) #14
Message was sent while issue was closed.
On 2017/01/27 16:33:58, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/61ef8268f9904aecb561105246c9...

AAARRRRGGGHHH...the context param removal again!  I obviously
learned my lesson the last time :-/

I'll reland this with the fix now.  Sorry!!!

Powered by Google App Engine
This is Rietveld 408576698