Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2653753008: Destroy incognito profile from close all incognito notification. (Closed)

Created:
3 years, 11 months ago by Ted C
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Destroy incognito profile from close all incognito notification. Also destroy the incognito profile when starting up tabbed mode and there are no discoverable incognito tabs around. BUG=673489 Review-Url: https://codereview.chromium.org/2649773007 Cr-Original-Commit-Position: refs/heads/master@{#446140} Review-Url: https://codereview.chromium.org/2653753008 . Cr-Commit-Position: refs/branch-heads/2987@{#115} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/29a4956a7ff9985a5e2b951d41b435d1b3d38b94

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 5 chunks +62 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java View 2 chunks +15 lines, -4 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/BrowserStartupController.java View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Ted C
Committed patchset #1 (id:1) manually as 29a4956a7ff9985a5e2b951d41b435d1b3d38b94.
3 years, 11 months ago (2017-01-26 19:43:22 UTC) #2
amineer
3 years, 10 months ago (2017-01-27 16:15:05 UTC) #3
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2655383003/ by amineer@chromium.org.

The reason for reverting is: Breaks build:

../../chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java:84:
error: method get in class BrowserStartupController cannot be applied to given
types;
                if
(BrowserStartupController.get(LibraryProcessType.PROCESS_BROWSER)
                                            ^
  required: Context,int
  found: int
  reason: actual and formal argument lists differ in length

https://uberchromegw.corp.google.com/i/official.android.continuous/builders/b....

Powered by Google App Engine
This is Rietveld 408576698