Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1327)

Issue 2649773007: Destroy incognito profile from close all incognito notification. (Closed)

Created:
3 years, 11 months ago by Ted C
Modified:
3 years, 11 months ago
Reviewers:
Theresa
CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Destroy incognito profile from close all incognito notification. Also destroy the incognito profile when starting up tabbed mode and there are no discoverable incognito tabs around. BUG=673489 Review-Url: https://codereview.chromium.org/2649773007 Cr-Commit-Position: refs/heads/master@{#446140} Committed: https://chromium.googlesource.com/chromium/src/+/e0c69147ed32a028eb8773d24b14fa0509363988

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Fix comment #

Patch Set 4 : Fix findbugs #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 1 2 5 chunks +62 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java View 1 2 3 2 chunks +15 lines, -4 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/BrowserStartupController.java View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Ted C
PTAL
3 years, 11 months ago (2017-01-24 22:25:14 UTC) #2
Theresa
lgtm https://codereview.chromium.org/2649773007/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java (right): https://codereview.chromium.org/2649773007/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java#newcode467 chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java:467: // In this case, we have tabbed mode ...
3 years, 11 months ago (2017-01-25 17:07:40 UTC) #3
Ted C
https://codereview.chromium.org/2649773007/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java (right): https://codereview.chromium.org/2649773007/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java#newcode467 chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java:467: // In this case, we have tabbed mode activities ...
3 years, 11 months ago (2017-01-25 18:29:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649773007/40001
3 years, 11 months ago (2017-01-25 18:29:27 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/200731)
3 years, 11 months ago (2017-01-25 20:07:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649773007/80001
3 years, 11 months ago (2017-01-25 21:09:55 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 22:11:28 UTC) #15
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/e0c69147ed32a028eb8773d24b14...

Powered by Google App Engine
This is Rietveld 408576698