NQE: Record the number of RTT and throughput samples received

NQE: Record the number of RTT and throughput samples received

NetworkQualityEstimator (NQE): Record the number of RTT and throughput 
samples received or synthesized.

BUG=688879
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2654033010
Cr-Commit-Position: refs/heads/master@{#448198}
Committed: https://chromium.googlesource.com/chromium/src/+/0924e3fb0383f04dbcf6919dcd7465137b308ba1

[tbansal1, 2017-01-27 01:58:24]

Description was changed from

==========
Record the number of samples received

BUG=
==========

to

==========
NQE: Record the number of RTT and throughput samples received

NetworkQualityEstimator (NQE): Record the number of RTT and throughput 
samples received or synthesized.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tbansal1, 2017-01-27 01:58:31]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 01:59:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 04:29:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 04:29:59]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[tbansal1, 2017-01-27 21:52:24]

tbansal@chromium.org changed reviewers:
+ ryansturm@chromium.org

[tbansal1, 2017-01-27 21:52:24]

ryansturm: ptal. Thanks.

[RyanSturm, 2017-01-31 19:57:57]

lgtm % nits

https://codereview.chromium.org/2654033010/diff/1/net/nqe/network_quality_est...
File net/nqe/network_quality_estimator_unittest.cc (right):

https://codereview.chromium.org/2654033010/diff/1/net/nqe/network_quality_est...
net/nqe/network_quality_estimator_unittest.cc:51: void
VerifyBucketCountAtLeast(base::HistogramTester* histogram_tester,
I feel like this could be generalized in the HistogramTester code, but that is
not for me to say.

If not, maybe a consistent name:
s/VerifyBucketCountAtLeast/ExpectBucketCountAtLeast/

https://codereview.chromium.org/2654033010/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2654033010/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:41092: + 
<owner>bengr@chromium.org</owner>
nit: you keep flip-flopping between adding bengr as the first listed owner and
adding yourself as the first listed owner. Always list yourself as the first
owner for NQE.

[tbansal1, 2017-02-02 02:34:34]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 02:34:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2017-02-02 02:35:35]

tbansal@chromium.org changed reviewers:
+ rkaplow@chromium.org

[tbansal1, 2017-02-02 02:35:36]

rkaplow: ptal at histograms.xml. Thanks.

https://codereview.chromium.org/2654033010/diff/1/net/nqe/network_quality_est...
File net/nqe/network_quality_estimator_unittest.cc (right):

https://codereview.chromium.org/2654033010/diff/1/net/nqe/network_quality_est...
net/nqe/network_quality_estimator_unittest.cc:51: void
VerifyBucketCountAtLeast(base::HistogramTester* histogram_tester,
On 2017/01/31 19:57:57, Ryan Sturm wrote:
> I feel like this could be generalized in the HistogramTester code, but that is
> not for me to say.
> 
> If not, maybe a consistent name:
> s/VerifyBucketCountAtLeast/ExpectBucketCountAtLeast/

Done.

https://codereview.chromium.org/2654033010/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2654033010/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:41092: + 
<owner>bengr@chromium.org</owner>
On 2017/01/31 19:57:57, Ryan Sturm wrote:
> nit: you keep flip-flopping between adding bengr as the first listed owner and
> adding yourself as the first listed owner. Always list yourself as the first
> owner for NQE.

Done.

[commit-bot: I haz the power, 2017-02-02 06:25:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 06:25:11]

Dry run: This issue passed the CQ dry run.

[rkaplow, 2017-02-03 03:17:43]

lgtm

[tbansal1, 2017-02-04 00:38:30]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2017-02-04 00:38:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
ryansturm@chromium.org
Link to the patchset: https://codereview.chromium.org/2654033010/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2017-02-04 00:38:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2017-02-04 00:39:22]

The CQ bit was unchecked by tbansal@chromium.org

[tbansal1, 2017-02-04 00:39:35]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-04 00:40:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 00:41:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-04 00:41:45]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[tbansal1, 2017-02-04 09:48:59]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-04 09:49:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 11:49:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-04 11:49:32]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_TIMED_OUT,
no build URL)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no
build URL)
  win_clang on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL)

[tbansal1, 2017-02-04 15:56:43]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-04 15:56:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 17:57:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-04 17:57:31]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_TIMED_OUT,
no build URL)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no
build URL)
  win_clang on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL)

[tbansal1, 2017-02-04 18:00:14]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-04 18:00:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 20:00:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-04 20:00:48]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_TIMED_OUT,
no build URL)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no
build URL)
  win_clang on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL)

[tbansal1, 2017-02-04 21:44:31]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-04 21:44:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 23:45:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-04 23:45:14]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[tbansal1, 2017-02-05 04:30:29]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-05 04:30:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-05 05:22:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-05 05:22:34]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2017-02-06 00:10:26]

Description was changed from

==========
NQE: Record the number of RTT and throughput samples received

NetworkQualityEstimator (NQE): Record the number of RTT and throughput 
samples received or synthesized.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
NQE: Record the number of RTT and throughput samples received

NetworkQualityEstimator (NQE): Record the number of RTT and throughput 
samples received or synthesized.

BUG=688879
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tbansal1, 2017-02-06 00:10:36]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2017-02-06 00:10:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
ryansturm@chromium.org, rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2654033010/#ps80001
(title: "Fix test")

[commit-bot: I haz the power, 2017-02-06 00:10:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 00:39:26]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1486339836595720,
"parent_rev": "0ecb6861b457c65a8c5ba6789d1b57bd6c44c61c", "commit_rev":
"0924e3fb0383f04dbcf6919dcd7465137b308ba1"}

[commit-bot: I haz the power, 2017-02-06 00:39:56]

Description was changed from

==========
NQE: Record the number of RTT and throughput samples received

NetworkQualityEstimator (NQE): Record the number of RTT and throughput 
samples received or synthesized.

BUG=688879
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
NQE: Record the number of RTT and throughput samples received

NetworkQualityEstimator (NQE): Record the number of RTT and throughput 
samples received or synthesized.

BUG=688879
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2654033010
Cr-Commit-Position: refs/heads/master@{#448198}
Committed:
https://chromium.googlesource.com/chromium/src/+/0924e3fb0383f04dbcf6919dcd74...
==========

[commit-bot: I haz the power, 2017-02-06 00:39:57]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/0924e3fb0383f04dbcf6919dcd74...