Chromium Code Reviews Chromium Code Reviews
Issue 2654033010:
NQE: Record the number of RTT and throughput samples received (Closed)
| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 35b3c77107264ab91d2e3857942a0935bf1b0875..0c84181a4c66b634192f7b62af9f46818a7fc94d 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -41088,6 +41088,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="NQE.Kbps.ObservationSource" enum="NQEObservationSource"> |
| + <owner>bengr@chromium.org</owner> |
|
RyanSturm
2017/01/31 19:57:57
nit: you keep flip-flopping between adding bengr a
tbansal1
2017/02/02 02:35:36
Done.
|
| + <owner>tbansal@chromium.org</owner> |
| + <summary> |
| + Number of Kbps observations indexed by the source of the observation. |
| + Recorded by the network quality estimator every time a new observation is |
| + made or synthesized. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="NQE.MainFrame.EffectiveConnectionType" |
| enum="NQEEffectiveConnectionType"> |
| <owner>tbansal@chromium.org</owner> |
| @@ -41208,6 +41218,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="NQE.RTT.ObservationSource" enum="NQEObservationSource"> |
| + <owner>bengr@chromium.org</owner> |
| + <owner>tbansal@chromium.org</owner> |
| + <summary> |
| + Number of RTT observations indexed by the source of the observation. |
| + Recorded by the network quality estimator every time a new observation is |
| + made or synthesized. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="NQE.RTTObservations" units="ms"> |
| <obsolete> |
| Replaced in May 2016 by NQE.MainFrame.RTT.* metrics. |
| @@ -99385,6 +99405,17 @@ value. |
| provider"/> |
| </enum> |
| +<enum name="NQEObservationSource" type="int"> |
| + <int value="0" label="HTTP"/> |
| + <int value="1" label="TCP"/> |
| + <int value="2" label="QUIC"/> |
| + <int value="3" label="HTTP-layer cached"/> |
| + <int value="4" label="HTTP-layer default"/> |
| + <int value="5" label="HTTP-layer external estimate provider"/> |
| + <int value="6" label="Transport-layer cached"/> |
| + <int value="7" label="Transport-layer default"/> |
| +</enum> |
| + |
| <enum name="NtpFollowAction" type="int"> |
| <int value="0" label="PAGE_TRANSITION_LINK"/> |
| <int value="1" label="PAGE_TRANSITION_TYPED"/> |
