Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: net/nqe/network_quality_estimator.h

Issue 2654033010: NQE: Record the number of RTT and throughput samples received (Closed)
Patch Set: Fix test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/nqe/network_quality_estimator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/nqe/network_quality_estimator.h
diff --git a/net/nqe/network_quality_estimator.h b/net/nqe/network_quality_estimator.h
index 111248bb048d8a68551945dbf5830865d827d53e..21db66fc7189cb2fc86d171124eefba2922a2346 100644
--- a/net/nqe/network_quality_estimator.h
+++ b/net/nqe/network_quality_estimator.h
@@ -380,6 +380,11 @@ class NET_EXPORT NetworkQualityEstimator
base::TimeDelta* transport_rtt,
int32_t* downstream_throughput_kbps) const;
+ // Notifies |this| of a new transport layer RTT. Called by socket watchers.
+ // Protected for testing.
+ void OnUpdatedRTTAvailable(SocketPerformanceWatcherFactory::Protocol protocol,
+ const base::TimeDelta& rtt);
+
private:
FRIEND_TEST_ALL_PREFIXES(NetworkQualityEstimatorTest,
AdaptiveRecomputationEffectiveConnectionType);
@@ -467,10 +472,6 @@ class NET_EXPORT NetworkQualityEstimator
// throughput in kilobits per second.
void OnNewThroughputObservationAvailable(int32_t downstream_kbps);
- // Notifies |this| of a new transport layer RTT.
- void OnUpdatedRTTAvailable(SocketPerformanceWatcherFactory::Protocol protocol,
- const base::TimeDelta& rtt);
-
// Obtains the model parameters for different effective connection types from
// the field trial parameters. For each effective connection type, a model
// (currently composed of a RTT threshold and a downlink throughput threshold)
« no previous file with comments | « no previous file | net/nqe/network_quality_estimator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698