cros: Clear out LoginDisplayHostImpl::login_view_ before login_window_.

cros: Clear out LoginDisplayHostImpl::login_view_ before login_window_.

login_window_ owns the login_view_ instance; closing login_window_ could
invalidate the login_view_ pointer.

BUG=672142
Review-Url: https://codereview.chromium.org/2654003008
Cr-Commit-Position: refs/heads/master@{#448470}
Committed: https://chromium.googlesource.com/chromium/src/+/e7952a26a6078a70081aa24d4d62a0c478badc28

[jdufault, 2017-01-26 19:57:54]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 19:58:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 20:33:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 20:33:09]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-02-06 22:22:45]

Description was changed from

==========
cros: Clear out LoginDisplayHostImpl::login_view_ before login_window_.

login_window_ owns the login_view_ instance; closing login_window_ could
invalidate the login_view_ pointer.

BUG=672142
==========

to

==========
cros: Clear out LoginDisplayHostImpl::login_view_ before login_window_.

login_window_ owns the login_view_ instance; closing login_window_ could
invalidate the login_view_ pointer.

BUG=672142
==========

[jdufault, 2017-02-06 22:22:45]

jdufault@chromium.org changed reviewers:
+ alemate@chromium.org

[jdufault, 2017-02-06 22:22:52]

alemate@ PTAL.

[achuithb, 2017-02-06 22:38:57]

achuith@chromium.org changed reviewers:
+ achuith@chromium.org

[achuithb, 2017-02-06 22:38:58]

lgtm

https://codereview.chromium.org/2654003008/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/ui/login_display_host_impl.cc (right):

https://codereview.chromium.org/2654003008/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/ui/login_display_host_impl.cc:1161: if
(!login_view_)
Please add a comment explaining why this order is important.

Are these early returns appropriate? Should this be:

if (login_view_) {
  login_view_->SetUIEnabled(true);
  login_view_ = nullptr;
}
if (login_window_) {
  login_window_->Close();
  login_window_ = nullptr;
}

[jdufault, 2017-02-06 22:52:10]

https://codereview.chromium.org/2654003008/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/ui/login_display_host_impl.cc (right):

https://codereview.chromium.org/2654003008/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/ui/login_display_host_impl.cc:1161: if
(!login_view_)
On 2017/02/06 22:38:58, achuithb wrote:
> Please add a comment explaining why this order is important.
> 
> Are these early returns appropriate? Should this be:
> 
> if (login_view_) {
>   login_view_->SetUIEnabled(true);
>   login_view_ = nullptr;
> }
> if (login_window_) {
>   login_window_->Close();
>   login_window_ = nullptr;
> }

Done.

[jdufault, 2017-02-06 23:49:45]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2017-02-06 23:49:45]

The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org
Link to the patchset: https://codereview.chromium.org/2654003008/#ps40001
(title: "Add comment, do not use inverted ifs")

[commit-bot: I haz the power, 2017-02-06 23:51:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 00:44:52]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486424985268370,
"parent_rev": "07d5dfc4ea28b2dc2c006973015ee147ad2b7715", "commit_rev":
"e7952a26a6078a70081aa24d4d62a0c478badc28"}

[commit-bot: I haz the power, 2017-02-07 00:45:29]

Description was changed from

==========
cros: Clear out LoginDisplayHostImpl::login_view_ before login_window_.

login_window_ owns the login_view_ instance; closing login_window_ could
invalidate the login_view_ pointer.

BUG=672142
==========

to

==========
cros: Clear out LoginDisplayHostImpl::login_view_ before login_window_.

login_window_ owns the login_view_ instance; closing login_window_ could
invalidate the login_view_ pointer.

BUG=672142

Review-Url: https://codereview.chromium.org/2654003008
Cr-Commit-Position: refs/heads/master@{#448470}
Committed:
https://chromium.googlesource.com/chromium/src/+/e7952a26a6078a70081aa24d4d62...
==========

[commit-bot: I haz the power, 2017-02-07 00:45:30]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e7952a26a6078a70081aa24d4d62...