Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Side by Side Diff: chrome/browser/chromeos/login/ui/login_display_host_impl.h

Issue 2654003008: cros: Clear out LoginDisplayHostImpl::login_view_ before login_window_. (Closed)
Patch Set: Add comment, do not use inverted ifs Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/ui/login_display_host_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_UI_LOGIN_DISPLAY_HOST_IMPL_H_ 5 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_UI_LOGIN_DISPLAY_HOST_IMPL_H_
6 #define CHROME_BROWSER_CHROMEOS_LOGIN_UI_LOGIN_DISPLAY_HOST_IMPL_H_ 6 #define CHROME_BROWSER_CHROMEOS_LOGIN_UI_LOGIN_DISPLAY_HOST_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 222
223 // ARC kiosk controller. 223 // ARC kiosk controller.
224 std::unique_ptr<ArcKioskController> arc_kiosk_controller_; 224 std::unique_ptr<ArcKioskController> arc_kiosk_controller_;
225 225
226 // Make sure chrome won't exit while we are at login/oobe screen. 226 // Make sure chrome won't exit while we are at login/oobe screen.
227 std::unique_ptr<ScopedKeepAlive> keep_alive_; 227 std::unique_ptr<ScopedKeepAlive> keep_alive_;
228 228
229 // Has ShutdownDisplayHost() already been called? Used to avoid posting our 229 // Has ShutdownDisplayHost() already been called? Used to avoid posting our
230 // own deletion to the message loop twice if the user logs out while we're 230 // own deletion to the message loop twice if the user logs out while we're
231 // still in the process of cleaning up after login (http://crbug.com/134463). 231 // still in the process of cleaning up after login (http://crbug.com/134463).
232 bool shutting_down_; 232 bool shutting_down_ = false;
233 233
234 // Whether progress bar is shown on the OOBE page. 234 // Whether progress bar is shown on the OOBE page.
235 bool oobe_progress_bar_visible_; 235 bool oobe_progress_bar_visible_ = false;
236 236
237 // True if session start is in progress. 237 // True if session start is in progress.
238 bool session_starting_; 238 bool session_starting_ = false;
239 239
240 // Container of the screen we are displaying. 240 // Container of the screen we are displaying.
241 views::Widget* login_window_; 241 views::Widget* login_window_ = nullptr;
242 242
243 // Container of the view we are displaying. 243 // Container of the view we are displaying.
244 WebUILoginView* login_view_; 244 WebUILoginView* login_view_ = nullptr;
245 245
246 // Login display we are using. 246 // Login display we are using.
247 WebUILoginDisplay* webui_login_display_; 247 WebUILoginDisplay* webui_login_display_ = nullptr;
248 248
249 // True if the login display is the current screen. 249 // True if the login display is the current screen.
250 bool is_showing_login_; 250 bool is_showing_login_ = false;
251 251
252 // True if NOTIFICATION_WALLPAPER_ANIMATION_FINISHED notification has been 252 // True if NOTIFICATION_WALLPAPER_ANIMATION_FINISHED notification has been
253 // received. 253 // received.
254 bool is_wallpaper_loaded_; 254 bool is_wallpaper_loaded_ = false;
255 255
256 // Stores status area current visibility to be applied once login WebUI 256 // Stores status area current visibility to be applied once login WebUI
257 // is shown. 257 // is shown.
258 bool status_area_saved_visibility_; 258 bool status_area_saved_visibility_ = false;
259 259
260 // If true, WebUI is initialized in a hidden state and shown after the 260 // If true, WebUI is initialized in a hidden state and shown after the
261 // wallpaper animation is finished (when it is enabled) or the user pods have 261 // wallpaper animation is finished (when it is enabled) or the user pods have
262 // been loaded (otherwise). 262 // been loaded (otherwise).
263 // By default is true. Could be used to tune performance if needed. 263 // By default is true. Could be used to tune performance if needed.
264 bool initialize_webui_hidden_; 264 bool initialize_webui_hidden_;
265 265
266 // True if WebUI is initialized in hidden state and we're waiting for 266 // True if WebUI is initialized in hidden state and we're waiting for
267 // wallpaper load animation to finish. 267 // wallpaper load animation to finish.
268 bool waiting_for_wallpaper_load_; 268 bool waiting_for_wallpaper_load_;
269 269
270 // True if WebUI is initialized in hidden state and we're waiting for user 270 // True if WebUI is initialized in hidden state and we're waiting for user
271 // pods to load. 271 // pods to load.
272 bool waiting_for_user_pods_; 272 bool waiting_for_user_pods_;
273 273
274 // How many times renderer has crashed. 274 // How many times renderer has crashed.
275 int crash_count_; 275 int crash_count_ = 0;
276 276
277 // Way to restore if renderer have crashed. 277 // Way to restore if renderer have crashed.
278 RestorePath restore_path_; 278 RestorePath restore_path_ = RESTORE_UNKNOWN;
279 279
280 // Stored parameters for StartWizard, required to restore in case of crash. 280 // Stored parameters for StartWizard, required to restore in case of crash.
281 OobeScreen first_screen_; 281 OobeScreen first_screen_;
282 282
283 // Called before host deletion. 283 // Called before host deletion.
284 base::Closure completion_callback_; 284 base::Closure completion_callback_;
285 285
286 // Active instance of authentication prewarmer. 286 // Active instance of authentication prewarmer.
287 std::unique_ptr<AuthPrewarmer> auth_prewarmer_; 287 std::unique_ptr<AuthPrewarmer> auth_prewarmer_;
288 288
289 // A focus ring controller to draw focus ring around view for keyboard 289 // A focus ring controller to draw focus ring around view for keyboard
290 // driven oobe. 290 // driven oobe.
291 std::unique_ptr<FocusRingController> focus_ring_controller_; 291 std::unique_ptr<FocusRingController> focus_ring_controller_;
292 292
293 // Handles special keys for keyboard driven oobe. 293 // Handles special keys for keyboard driven oobe.
294 std::unique_ptr<KeyboardDrivenOobeKeyHandler> 294 std::unique_ptr<KeyboardDrivenOobeKeyHandler>
295 keyboard_driven_oobe_key_handler_; 295 keyboard_driven_oobe_key_handler_;
296 296
297 FinalizeAnimationType finalize_animation_type_; 297 FinalizeAnimationType finalize_animation_type_ = ANIMATION_WORKSPACE;
298 298
299 // Time when login prompt visible signal is received. Used for 299 // Time when login prompt visible signal is received. Used for
300 // calculations of delay before startup sound. 300 // calculations of delay before startup sound.
301 base::TimeTicks login_prompt_visible_time_; 301 base::TimeTicks login_prompt_visible_time_;
302 302
303 // True when request to play startup sound was sent to 303 // True when request to play startup sound was sent to
304 // SoundsManager. 304 // SoundsManager.
305 bool startup_sound_played_; 305 bool startup_sound_played_ = false;
306 306
307 // When true, startup sound should be played only when spoken 307 // When true, startup sound should be played only when spoken
308 // feedback is enabled. Otherwise, startup sound should be played 308 // feedback is enabled. Otherwise, startup sound should be played
309 // in any case. 309 // in any case.
310 bool startup_sound_honors_spoken_feedback_; 310 bool startup_sound_honors_spoken_feedback_ = false;
311 311
312 // True is subscribed as keyboard controller observer. 312 // True is subscribed as keyboard controller observer.
313 bool is_observing_keyboard_; 313 bool is_observing_keyboard_ = false;
314 314
315 // Keeps a copy of the old Drag'n'Drop client, so that it would be disabled 315 // Keeps a copy of the old Drag'n'Drop client, so that it would be disabled
316 // during a login session and restored afterwards. 316 // during a login session and restored afterwards.
317 std::unique_ptr<aura::client::ScopedDragDropDisabler> 317 std::unique_ptr<aura::client::ScopedDragDropDisabler>
318 scoped_drag_drop_disabler_; 318 scoped_drag_drop_disabler_;
319 319
320 base::WeakPtrFactory<LoginDisplayHostImpl> pointer_factory_; 320 base::WeakPtrFactory<LoginDisplayHostImpl> pointer_factory_;
321 base::WeakPtrFactory<LoginDisplayHostImpl> animation_weak_ptr_factory_; 321 base::WeakPtrFactory<LoginDisplayHostImpl> animation_weak_ptr_factory_;
322 322
323 DISALLOW_COPY_AND_ASSIGN(LoginDisplayHostImpl); 323 DISALLOW_COPY_AND_ASSIGN(LoginDisplayHostImpl);
324 }; 324 };
325 325
326 } // namespace chromeos 326 } // namespace chromeos
327 327
328 #endif // CHROME_BROWSER_CHROMEOS_LOGIN_UI_LOGIN_DISPLAY_HOST_IMPL_H_ 328 #endif // CHROME_BROWSER_CHROMEOS_LOGIN_UI_LOGIN_DISPLAY_HOST_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/ui/login_display_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698