Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4075)

Unified Diff: chrome/browser/chromeos/login/ui/login_display_host_impl.h

Issue 2654003008: cros: Clear out LoginDisplayHostImpl::login_view_ before login_window_. (Closed)
Patch Set: Add comment, do not use inverted ifs Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/ui/login_display_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/ui/login_display_host_impl.h
diff --git a/chrome/browser/chromeos/login/ui/login_display_host_impl.h b/chrome/browser/chromeos/login/ui/login_display_host_impl.h
index 565c76e65e64d25e67e4ee742d0a38eecf2dd8c6..008ee91ebffbc8b8f8e6b28fa834f70432eb9244 100644
--- a/chrome/browser/chromeos/login/ui/login_display_host_impl.h
+++ b/chrome/browser/chromeos/login/ui/login_display_host_impl.h
@@ -229,33 +229,33 @@ class LoginDisplayHostImpl : public LoginDisplayHost,
// Has ShutdownDisplayHost() already been called? Used to avoid posting our
// own deletion to the message loop twice if the user logs out while we're
// still in the process of cleaning up after login (http://crbug.com/134463).
- bool shutting_down_;
+ bool shutting_down_ = false;
// Whether progress bar is shown on the OOBE page.
- bool oobe_progress_bar_visible_;
+ bool oobe_progress_bar_visible_ = false;
// True if session start is in progress.
- bool session_starting_;
+ bool session_starting_ = false;
// Container of the screen we are displaying.
- views::Widget* login_window_;
+ views::Widget* login_window_ = nullptr;
// Container of the view we are displaying.
- WebUILoginView* login_view_;
+ WebUILoginView* login_view_ = nullptr;
// Login display we are using.
- WebUILoginDisplay* webui_login_display_;
+ WebUILoginDisplay* webui_login_display_ = nullptr;
// True if the login display is the current screen.
- bool is_showing_login_;
+ bool is_showing_login_ = false;
// True if NOTIFICATION_WALLPAPER_ANIMATION_FINISHED notification has been
// received.
- bool is_wallpaper_loaded_;
+ bool is_wallpaper_loaded_ = false;
// Stores status area current visibility to be applied once login WebUI
// is shown.
- bool status_area_saved_visibility_;
+ bool status_area_saved_visibility_ = false;
// If true, WebUI is initialized in a hidden state and shown after the
// wallpaper animation is finished (when it is enabled) or the user pods have
@@ -272,10 +272,10 @@ class LoginDisplayHostImpl : public LoginDisplayHost,
bool waiting_for_user_pods_;
// How many times renderer has crashed.
- int crash_count_;
+ int crash_count_ = 0;
// Way to restore if renderer have crashed.
- RestorePath restore_path_;
+ RestorePath restore_path_ = RESTORE_UNKNOWN;
// Stored parameters for StartWizard, required to restore in case of crash.
OobeScreen first_screen_;
@@ -294,7 +294,7 @@ class LoginDisplayHostImpl : public LoginDisplayHost,
std::unique_ptr<KeyboardDrivenOobeKeyHandler>
keyboard_driven_oobe_key_handler_;
- FinalizeAnimationType finalize_animation_type_;
+ FinalizeAnimationType finalize_animation_type_ = ANIMATION_WORKSPACE;
// Time when login prompt visible signal is received. Used for
// calculations of delay before startup sound.
@@ -302,15 +302,15 @@ class LoginDisplayHostImpl : public LoginDisplayHost,
// True when request to play startup sound was sent to
// SoundsManager.
- bool startup_sound_played_;
+ bool startup_sound_played_ = false;
// When true, startup sound should be played only when spoken
// feedback is enabled. Otherwise, startup sound should be played
// in any case.
- bool startup_sound_honors_spoken_feedback_;
+ bool startup_sound_honors_spoken_feedback_ = false;
// True is subscribed as keyboard controller observer.
- bool is_observing_keyboard_;
+ bool is_observing_keyboard_ = false;
// Keeps a copy of the old Drag'n'Drop client, so that it would be disabled
// during a login session and restored afterwards.
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/ui/login_display_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698