Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2653093002: [bindings] Allow dictionary and union types to be returned from static methods. (Closed)

Created:
3 years, 11 months ago by jbroman
Modified:
3 years, 11 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, alokp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[bindings] Allow dictionary and union types to be returned from static methods. Adds support to the bindings generator for a v8SetReturnValue overload which takes a creation context (which is usually the holder, but for static methods it is the creation context of the function itself), similar to how DOM wrappers are implemented. Updates the generator to emit calls to these functions rather than #error. Review-Url: https://codereview.chromium.org/2653093002 Cr-Commit-Position: refs/heads/master@{#445874} Committed: https://chromium.googlesource.com/chromium/src/+/5e555966db49bb5497a34c432527a44d76baf94a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -7 lines) Patch
M third_party/WebKit/Source/bindings/scripts/v8_types.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/dictionary_v8.h.tmpl View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/union_container.h.tmpl View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/ArrayBufferOrArrayBufferViewOrDictionary.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/BooleanOrStringOrUnrestrictedDouble.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/DoubleOrString.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/NodeOrNodeList.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/StringOrArrayBufferOrArrayBufferView.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/StringOrDouble.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/StringOrStringSequence.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestInterface2OrUint8Array.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrTestInterfaceEmpty.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/UnrestrictedDoubleOrString.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.h View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.h View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInit.h View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 4 chunks +36 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.h View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/BooleanOrString.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
jbroman
alokp's CL (https://codereview.chromium.org/2400563002/) needs this support if it wants to use a static method for ...
3 years, 11 months ago (2017-01-24 21:25:16 UTC) #6
haraken
LGTM
3 years, 11 months ago (2017-01-24 21:26:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653093002/1
3 years, 11 months ago (2017-01-24 21:28:39 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 00:29:33 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5e555966db49bb5497a34c432527...

Powered by Google App Engine
This is Rietveld 408576698