third_party/WebKit/Source/bindings/tests/results/core/DoubleOrString.h - Issue 2653093002: [bindings] Allow dictionary and union types to be returned from static methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/DoubleOrString.h

Issue 2653093002: [bindings] Allow dictionary and union types to be returned from static methods. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/BooleanOrStringOrUnrestrictedDouble.h ('k') | third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/DoubleOrString.h

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/DoubleOrString.h b/third_party/WebKit/Source/bindings/tests/results/core/DoubleOrString.h

index 4e24e6e52f0097a2c2c7d2aec9c379b4197134a4..8938fb0ccf1aeaa1cb911d4b406dda9206e4990c 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/DoubleOrString.h

+++ b/third_party/WebKit/Source/bindings/tests/results/core/DoubleOrString.h

@@ -67,6 +67,11 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, DoubleOrString& i

v8SetReturnValue(callbackInfo, ToV8(impl, callbackInfo.Holder(), callbackInfo.GetIsolate()));

}

+template <class CallbackInfo>

+inline void v8SetReturnValue(const CallbackInfo& callbackInfo, DoubleOrString& impl, v8::Local<v8::Object> creationContext) {

+ v8SetReturnValue(callbackInfo, ToV8(impl, creationContext, callbackInfo.GetIsolate()));

template <>

struct NativeValueTraits<DoubleOrString> {

CORE_EXPORT static DoubleOrString nativeValue(v8::Isolate*, v8::Local<v8::Value>, ExceptionState&);