Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_types.py

Issue 2653093002: [bindings] Allow dictionary and union types to be returned from static methods. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/templates/dictionary_v8.h.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/scripts/v8_types.py
diff --git a/third_party/WebKit/Source/bindings/scripts/v8_types.py b/third_party/WebKit/Source/bindings/scripts/v8_types.py
index b9c4750ec10e7d9cbd622dee72aca2efc97d113e..a4ebbbcbc38d94d32b43ed1e187a5987366616b1 100644
--- a/third_party/WebKit/Source/bindings/scripts/v8_types.py
+++ b/third_party/WebKit/Source/bindings/scripts/v8_types.py
@@ -838,10 +838,10 @@ V8_SET_RETURN_VALUE = {
'DictionaryStatic': '#error not implemented yet',
# Nullable dictionaries
'NullableDictionary': 'v8SetReturnValue(info, result.get())',
- 'NullableDictionaryStatic': '#error not implemented yet',
+ 'NullableDictionaryStatic': 'v8SetReturnValue(info, result.get(), info.GetIsolate()->GetCurrentContext()->Global())',
# Union types or dictionaries
'DictionaryOrUnion': 'v8SetReturnValue(info, result)',
- 'DictionaryOrUnionStatic': '#error not implemented yet',
+ 'DictionaryOrUnionStatic': 'v8SetReturnValue(info, result, info.GetIsolate()->GetCurrentContext()->Global())',
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/templates/dictionary_v8.h.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698