third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js - Issue 2652893008: DevTools: fix network waterfall sorting icon

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2652893008: DevTools: fix network waterfall sorting icon (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

index 7dc4d44a27b2aa373a0413b21a8b67c3accd6b10..37a7b2f2cbfb5768921c0e5765d6b01693e6961c 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

@@ -263,9 +263,9 @@ Network.NetworkLogViewColumns = class {

var columnId = this._dataGrid.sortColumnId();

this._networkLogView.removeAllNodeHighlights();

this._waterfallRequestsAreStale = true;

- if (columnId === 'waterfall') {

- this._waterfallColumnSortIcon.classList.remove('sort-ascending', 'sort-descending');

+ this._waterfallColumnSortIcon.classList.remove('sort-ascending', 'sort-descending');

+ if (columnId === 'waterfall') {

if (this._dataGrid.sortOrder() === DataGrid.DataGrid.Order.Ascending)

this._waterfallColumnSortIcon.classList.add('sort-ascending');

else

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/networkLogView.css » ('j') | no next file with comments »