Don't "repack" parameters in SVGElement::attributeChanged

Don't "repack" parameters in SVGElement::attributeChanged

Instead of making a AttributeModificationParams which always uses the
"directly" modification reason, just forward the original reason.
The 'reason' argument was added by [1] which did not indicate why SVG
elements would be subject to different treatment than regular elements.

[1] https://codereview.chromium.org/14234005

Review-Url: https://codereview.chromium.org/2652653002
Cr-Commit-Position: refs/heads/master@{#445698}
Committed: https://chromium.googlesource.com/chromium/src/+/a486c29cc95da9fc1ef8fbbb7aff8332e75dd2a1

[fs, 2017-01-23 13:05:51]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 13:06:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 14:50:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 14:50:52]

Dry run: This issue passed the CQ dry run.

[fs, 2017-01-23 14:54:19]

fs@opera.com changed reviewers:
+ mkwst@chromium.org

[fs, 2017-01-23 14:54:20]

mkwst (since you sort of landed the CL that added the 'directly'), any reason
that we're treating SVGElement differently than (HTML)Element here?

[Mike West, 2017-01-24 08:38:15]

I don't think there's any reason, no. If you, who know more about SVG than I do,
say it's not necessary, than LGTM.

[fs, 2017-01-24 08:56:42]

On 2017/01/24 at 08:38:15, mkwst wrote:
> I don't think there's any reason, no. If you, who know more about SVG than I
do, say it's not necessary, than LGTM.

I've examined the potential side-effects, and the "CSP vs. inline style" one is
the only relevant I could see, and that I think we want regardless of where the
inline style resides (HTMLElement or SVGElement.) So thanks for having a look,
I'll go ahead and land this.

[fs, 2017-01-24 09:10:53]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 09:11:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 11:06:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 11:06:05]

Dry run: This issue passed the CQ dry run.

[fs, 2017-01-24 11:18:21]

The CQ bit was checked by fs@opera.com

[fs, 2017-01-24 11:18:21]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2652653002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-24 11:18:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 11:22:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485256701249710,
"parent_rev": "f83bd839e1091f677d382fa8e6e8eb699d3706a3", "commit_rev":
"a486c29cc95da9fc1ef8fbbb7aff8332e75dd2a1"}

[commit-bot: I haz the power, 2017-01-24 11:23:11]

Description was changed from

==========
Don't "repack" parameters in SVGElement::attributeChanged

Instead of making a AttributeModificationParams which always uses the
"directly" modification reason, just forward the original reason.
The 'reason' argument was added by [1] which did not indicate why SVG
elements would be subject to different treatment than regular elements.

[1] https://codereview.chromium.org/14234005
==========

to

==========
Don't "repack" parameters in SVGElement::attributeChanged

Instead of making a AttributeModificationParams which always uses the
"directly" modification reason, just forward the original reason.
The 'reason' argument was added by [1] which did not indicate why SVG
elements would be subject to different treatment than regular elements.

[1] https://codereview.chromium.org/14234005

Review-Url: https://codereview.chromium.org/2652653002
Cr-Commit-Position: refs/heads/master@{#445698}
Committed:
https://chromium.googlesource.com/chromium/src/+/a486c29cc95da9fc1ef8fbbb7aff...
==========

[commit-bot: I haz the power, 2017-01-24 11:23:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a486c29cc95da9fc1ef8fbbb7aff...