Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 14234005: CSP blocks style application in cloned nodes (Closed)

Created:
7 years, 8 months ago by zimmerle
Modified:
7 years, 8 months ago
CC:
blink-reviews, pdr, Stephen Chennney, f(malita), mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

CSP blocks style application in cloned nodes Checks if the Element is being cloned, if so, the application of the style is allowed otherwise it relies on the CSP policy. Just re-landing the patch submitted to Webkit: https://bugs.webkit.org/show_bug.cgi?id=112270 Patch written by Felipe Zimmerle <felipe@zimmerle.org>; R=mkwst@chromium.org,abarth@chromium.org BUG=189184 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148384

Patch Set 1 #

Patch Set 2 : CSP blocks style application in cloned nodes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -16 lines) Patch
A LayoutTests/http/tests/security/contentSecurityPolicy/inline-style-allowed-while-cloning-objects.html View 1 chunk +86 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/security/contentSecurityPolicy/inline-style-allowed-while-cloning-objects-expected.txt View 1 chunk +37 lines, -0 lines 0 comments Download
M Source/WebCore/dom/Element.h View 1 2 chunks +7 lines, -2 lines 0 comments Download
M Source/WebCore/dom/Element.cpp View 1 5 chunks +5 lines, -5 lines 0 comments Download
M Source/WebCore/dom/StyledElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/dom/StyledElement.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/WebCore/svg/SVGElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/svg/SVGElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Mike West
Hi! Sorry it took so long to see this bug! Chromium's tools work a bit ...
7 years, 8 months ago (2013-04-15 08:38:08 UTC) #1
zimmerle
> Sorry it took so long to see this bug! Chromium's tools work a bit ...
7 years, 8 months ago (2013-04-15 17:00:22 UTC) #2
abarth-chromium
lgtm Sorry for not seeing this CL earlier!
7 years, 8 months ago (2013-04-15 17:05:13 UTC) #3
Mike West
On 2013/04/15 17:05:13, abarth wrote: > lgtm > > Sorry for not seeing this CL ...
7 years, 8 months ago (2013-04-15 18:15:02 UTC) #4
Mike West
Committed patchset #2 manually as r148384 (presubmit successful).
7 years, 8 months ago (2013-04-15 19:02:19 UTC) #5
Mike West
7 years, 8 months ago (2013-04-15 19:02:46 UTC) #6
Message was sent while issue was closed.
On 2013/04/15 19:02:19, Mike West (chromium) wrote:
> Committed patchset #2 manually as r148384 (presubmit successful).

I've landed this for you, thanks for your work!

Powered by Google App Engine
This is Rietveld 408576698