Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGElement.cpp

Issue 2652653002: Don't "repack" parameters in SVGElement::attributeChanged (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann
3 * <zimmermann@kde.org> 3 * <zimmermann@kde.org>
4 * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org> 4 * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org>
5 * Copyright (C) 2008 Apple Inc. All rights reserved. 5 * Copyright (C) 2008 Apple Inc. All rights reserved.
6 * Copyright (C) 2008 Alp Toker <alp@atoker.com> 6 * Copyright (C) 2008 Alp Toker <alp@atoker.com>
7 * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au> 7 * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 904 matching lines...) Expand 10 before | Expand all | Expand 10 after
915 if (document().loadEventFinished()) 915 if (document().loadEventFinished())
916 return; 916 return;
917 917
918 if (!parent || !parent->isSVGElement()) 918 if (!parent || !parent->isSVGElement())
919 return; 919 return;
920 920
921 toSVGElement(parent)->sendSVGLoadEventToSelfAndAncestorChainIfPossible(); 921 toSVGElement(parent)->sendSVGLoadEventToSelfAndAncestorChainIfPossible();
922 } 922 }
923 923
924 void SVGElement::attributeChanged(const AttributeModificationParams& params) { 924 void SVGElement::attributeChanged(const AttributeModificationParams& params) {
925 Element::attributeChanged( 925 Element::attributeChanged(params);
926 AttributeModificationParams(params.name, params.oldValue, params.newValue,
927 AttributeModificationReason::kDirectly));
928 926
929 if (params.name == HTMLNames::idAttr) { 927 if (params.name == HTMLNames::idAttr) {
930 rebuildAllIncomingReferences(); 928 rebuildAllIncomingReferences();
931 929
932 LayoutObject* object = layoutObject(); 930 LayoutObject* object = layoutObject();
933 // Notify resources about id changes, this is important as we cache 931 // Notify resources about id changes, this is important as we cache
934 // resources by id in SVGDocumentExtensions 932 // resources by id in SVGDocumentExtensions
935 if (object && object->isSVGResourceContainer()) 933 if (object && object->isSVGResourceContainer())
936 toLayoutSVGResourceContainer(object)->idChanged(); 934 toLayoutSVGResourceContainer(object)->idChanged();
937 if (isConnected()) 935 if (isConnected())
(...skipping 353 matching lines...) Expand 10 before | Expand all | Expand 10 after
1291 visitor->trace(m_className); 1289 visitor->trace(m_className);
1292 Element::trace(visitor); 1290 Element::trace(visitor);
1293 } 1291 }
1294 1292
1295 const AtomicString& SVGElement::eventParameterName() { 1293 const AtomicString& SVGElement::eventParameterName() {
1296 DEFINE_STATIC_LOCAL(const AtomicString, evtString, ("evt")); 1294 DEFINE_STATIC_LOCAL(const AtomicString, evtString, ("evt"));
1297 return evtString; 1295 return evtString;
1298 } 1296 }
1299 1297
1300 } // namespace blink 1298 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698