Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 2652253003: Revert of Use TaskRunnerTimer in PingLoader (Closed)

Created:
3 years, 10 months ago by Charlie Harrison
Modified:
3 years, 10 months ago
Reviewers:
kinuko, yhirano
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Revert of Use TaskRunnerTimer in PingLoader (patchset #1 id:1 of https://codereview.chromium.org/2646523002/ ) Reason for revert: Pingloader should have its timeout persist after frame destruction. Original issue's description: > Use TaskRunnerTimer in PingLoader > > Blocker for the per-frame scheduler. > > BUG=624694 > > Review-Url: https://codereview.chromium.org/2646523002 > Cr-Commit-Position: refs/heads/master@{#444627} > Committed: https://chromium.googlesource.com/chromium/src/+/81f01201993a78e1c89d70f11bc90b636a53cc99 TBR=yhirano@chromium.org, kinuko@chromium.org BUG=624694, 683900 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2654463002 Cr-Commit-Position: refs/heads/master@{#445380} (cherry picked from commit 49db2761173c14255f053871fb0b862dcf57fda3) Review-Url: https://codereview.chromium.org/2652253003 Cr-Commit-Position: refs/branch-heads/2987@{#91} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/d2d32dbc7514e959b3dd4c8b739a13d3f6d80a7b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M third_party/WebKit/Source/core/loader/PingLoader.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoader.cpp View 4 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Charlie Harrison
tbr yhirano, kinuko for merging to M57
3 years, 10 months ago (2017-01-25 18:26:19 UTC) #2
Charlie Harrison
actually +kinuko for TBR
3 years, 10 months ago (2017-01-25 18:26:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652253003/1
3 years, 10 months ago (2017-01-25 18:27:11 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-01-25 18:28:55 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d2d32dbc7514e959b3dd4c8b739a...

Powered by Google App Engine
This is Rietveld 408576698