Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2646523002: Use TaskRunnerTimer in PingLoader (Closed)

Created:
3 years, 11 months ago by Charlie Harrison
Modified:
3 years, 11 months ago
Reviewers:
yhirano
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use TaskRunnerTimer in PingLoader Blocker for the per-frame scheduler. BUG=624694 Review-Url: https://codereview.chromium.org/2646523002 Cr-Commit-Position: refs/heads/master@{#444627} Committed: https://chromium.googlesource.com/chromium/src/+/81f01201993a78e1c89d70f11bc90b636a53cc99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M third_party/WebKit/Source/core/loader/PingLoader.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoader.cpp View 4 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Charlie Harrison
Hey yhirano, here's another TaskRunnerTimer CL. PTAL?
3 years, 11 months ago (2017-01-18 17:02:12 UTC) #4
yhirano
lgtm
3 years, 11 months ago (2017-01-19 03:36:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646523002/1
3 years, 11 months ago (2017-01-19 03:39:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/81f01201993a78e1c89d70f11bc90b636a53cc99
3 years, 11 months ago (2017-01-19 03:44:47 UTC) #12
kinuko
In my understanding PingLoader is supposed to stay alive independently from LocalFrame and it looks ...
3 years, 11 months ago (2017-01-23 07:35:02 UTC) #13
Charlie Harrison
I think you have a good point. Let's revert for right now and find a ...
3 years, 11 months ago (2017-01-23 13:04:52 UTC) #14
Charlie Harrison
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2654463002/ by csharrison@chromium.org. ...
3 years, 11 months ago (2017-01-23 13:05:36 UTC) #15
Charlie Harrison
3 years, 11 months ago (2017-01-23 13:13:16 UTC) #16
Message was sent while issue was closed.
Probably this should just go with the default task runner, but I see you
mentioned this case on platform-architecture-dev, so I'll see what people think.

Powered by Google App Engine
This is Rietveld 408576698