Use TaskRunnerTimer in PingLoader

Use TaskRunnerTimer in PingLoader

Blocker for the per-frame scheduler.

BUG=624694
Review-Url: https://codereview.chromium.org/2646523002
Cr-Commit-Position: refs/heads/master@{#444627}
Committed: https://chromium.googlesource.com/chromium/src/+/81f01201993a78e1c89d70f11bc90b636a53cc99

[Charlie Harrison, 2017-01-18 16:46:28]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 16:46:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2017-01-18 17:02:11]

csharrison@chromium.org changed reviewers:
+ yhirano@chromium.org

[Charlie Harrison, 2017-01-18 17:02:12]

Hey yhirano, here's another TaskRunnerTimer CL. PTAL?

[commit-bot: I haz the power, 2017-01-18 19:00:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 19:00:49]

Dry run: This issue passed the CQ dry run.

[yhirano, 2017-01-19 03:36:21]

lgtm

[Charlie Harrison, 2017-01-19 03:39:21]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2017-01-19 03:39:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 03:44:19]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484797161224850, "parent_rev":
"70d68520b1de91df258ee82e589a7b5455790b8c", "commit_rev":
"81f01201993a78e1c89d70f11bc90b636a53cc99"}

[commit-bot: I haz the power, 2017-01-19 03:44:47]

Description was changed from

==========
Use TaskRunnerTimer in PingLoader

Blocker for the per-frame scheduler.

BUG=624694
==========

to

==========
Use TaskRunnerTimer in PingLoader

Blocker for the per-frame scheduler.

BUG=624694

Review-Url: https://codereview.chromium.org/2646523002
Cr-Commit-Position: refs/heads/master@{#444627}
Committed:
https://chromium.googlesource.com/chromium/src/+/81f01201993a78e1c89d70f11bc9...
==========

[commit-bot: I haz the power, 2017-01-19 03:44:47]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/81f01201993a78e1c89d70f11bc9...

[kinuko, 2017-01-23 07:35:02]

In my understanding PingLoader is supposed to stay alive independently from
LocalFrame and it looks it holds SelfKeepAlive until the timeout fires if the
server doesn't respond.  Would this change be really safe?

[Charlie Harrison, 2017-01-23 13:04:52]

I think you have a good point. Let's revert for right now and find a better
solution.

[Charlie Harrison, 2017-01-23 13:05:36]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2654463002/ by csharrison@chromium.org.

The reason for reverting is: Pingloader should have its timeout persist after
frame destruction..

[Charlie Harrison, 2017-01-23 13:13:16]

Probably this should just go with the default task runner, but I see you
mentioned this case on platform-architecture-dev, so I'll see what people think.