Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2654463002: Revert of Use TaskRunnerTimer in PingLoader (Closed)

Created:
3 years, 11 months ago by Charlie Harrison
Modified:
3 years, 11 months ago
Reviewers:
yhirano
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use TaskRunnerTimer in PingLoader (patchset #1 id:1 of https://codereview.chromium.org/2646523002/ ) Reason for revert: Pingloader should have its timeout persist after frame destruction. Original issue's description: > Use TaskRunnerTimer in PingLoader > > Blocker for the per-frame scheduler. > > BUG=624694 > > Review-Url: https://codereview.chromium.org/2646523002 > Cr-Commit-Position: refs/heads/master@{#444627} > Committed: https://chromium.googlesource.com/chromium/src/+/81f01201993a78e1c89d70f11bc90b636a53cc99 TBR=yhirano@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=624694, 683900 Review-Url: https://codereview.chromium.org/2654463002 Cr-Commit-Position: refs/heads/master@{#445380} Committed: https://chromium.googlesource.com/chromium/src/+/49db2761173c14255f053871fb0b862dcf57fda3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M third_party/WebKit/Source/core/loader/PingLoader.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoader.cpp View 4 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Charlie Harrison
Created Revert of Use TaskRunnerTimer in PingLoader
3 years, 11 months ago (2017-01-23 13:05:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654463002/1
3 years, 11 months ago (2017-01-23 13:05:54 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/334256)
3 years, 11 months ago (2017-01-23 13:07:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654463002/1
3 years, 11 months ago (2017-01-23 13:20:07 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 15:40:15 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/49db2761173c14255f053871fb0b...

Powered by Google App Engine
This is Rietveld 408576698