Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Issue 2652173002: DevTools: migrate UI.ListWidget icons over to UI.Icon (Closed)

Created:
3 years, 11 months ago by lushnikov
Modified:
3 years, 11 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: migrate UI.ListWidget icons over to UI.Icon This patch migrates "edit" and "remove" icons in the ListWidget to the UI.Icon. BUG=669323 R=dgozman Review-Url: https://codereview.chromium.org/2652173002 Cr-Commit-Position: refs/heads/master@{#446252} Committed: https://chromium.googlesource.com/chromium/src/+/6e9b9e99c6b3373d611d81d83f431fdbba9bf04f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -13 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/Icon.js View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/listWidget.css View 1 chunk +0 lines, -11 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
lushnikov
please, take a look
3 years, 11 months ago (2017-01-25 06:58:05 UTC) #1
dgozman
lgtm
3 years, 11 months ago (2017-01-25 19:54:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652173002/1
3 years, 11 months ago (2017-01-26 06:21:53 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 06:30:05 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6e9b9e99c6b3373d611d81d83f43...

Powered by Google App Engine
This is Rietveld 408576698