Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2657743003: DevTools: migrate icons in "search across files" to UI.Icon (Closed)

Created:
3 years, 11 months ago by lushnikov
Modified:
3 years, 11 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: migrate icons in "search across files" to UI.Icon This patch migrates to small icons in the search input field: the "looking glass" icon and the "clear search" icon. BUG=669323 R=dgozman Review-Url: https://codereview.chromium.org/2657743003 Cr-Commit-Position: refs/heads/master@{#446239} Committed: https://chromium.googlesource.com/chromium/src/+/99fb0a7ab0aa355d6d2bd17ca0d6940b57ec44b4

Patch Set 1 #

Patch Set 2 : nits #

Total comments: 4

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -36 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js View 1 2 4 chunks +11 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/sourcesSearch.css View 1 3 chunks +4 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Icon.js View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
lushnikov
please, take a look
3 years, 11 months ago (2017-01-25 06:54:48 UTC) #1
dgozman
lgtm https://codereview.chromium.org/2657743003/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/Icon.js File third_party/WebKit/Source/devtools/front_end/ui/Icon.js (right): https://codereview.chromium.org/2657743003/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/Icon.js#newcode119 third_party/WebKit/Source/devtools/front_end/ui/Icon.js:119: 'smallicon-search-sources': {x: -234, y: -30, width: 12, height: ...
3 years, 11 months ago (2017-01-25 17:56:37 UTC) #6
lushnikov
Thanks, all done. https://codereview.chromium.org/2657743003/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/Icon.js File third_party/WebKit/Source/devtools/front_end/ui/Icon.js (right): https://codereview.chromium.org/2657743003/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/Icon.js#newcode119 third_party/WebKit/Source/devtools/front_end/ui/Icon.js:119: 'smallicon-search-sources': {x: -234, y: -30, width: ...
3 years, 11 months ago (2017-01-26 00:52:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657743003/40001
3 years, 11 months ago (2017-01-26 00:53:27 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/220491)
3 years, 11 months ago (2017-01-26 04:20:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657743003/40001
3 years, 11 months ago (2017-01-26 04:21:35 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 05:46:07 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/99fb0a7ab0aa355d6d2bd17ca0d6...

Powered by Google App Engine
This is Rietveld 408576698