DevTools: migrate SoftContextMenu icons over to UI.Icon

DevTools: migrate SoftContextMenu icons over to UI.Icon

This patch migrates the checkmark icon in the SoftContextMenu over to
the UI.Icon.

BUG=669323
R=dgozman

Review-Url: https://codereview.chromium.org/2652153003
Cr-Commit-Position: refs/heads/master@{#446291}
Committed: https://chromium.googlesource.com/chromium/src/+/73df3267dc9ccbbfe1cde0f25e013e2c96c14f41

[lushnikov, 2017-01-25 07:03:52]

please, take a look

[lushnikov, 2017-01-25 07:03:57]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 07:04:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 09:00:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 09:00:12]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-01-25 19:57:39]

https://codereview.chromium.org/2652153003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/softContextMenu.css
(right):

https://codereview.chromium.org/2652153003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/softContextMenu.css:105:
.soft-context-menu-item-mouse-over .checkmark {
Doesn't this make them visible on hover even for non-checkmark items?

[lushnikov, 2017-01-26 00:54:55]

https://codereview.chromium.org/2652153003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/softContextMenu.css
(right):

https://codereview.chromium.org/2652153003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/softContextMenu.css:105:
.soft-context-menu-item-mouse-over .checkmark {
On 2017/01/25 19:57:39, dgozman wrote:
> Doesn't this make them visible on hover even for non-checkmark items?

No, the JS code sets opacity 0 in the inline style of such elements, which has
higher priority

[dgozman, 2017-01-26 02:36:59]

thanks, lgtm

[lushnikov, 2017-01-26 06:31:42]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-01-26 06:32:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 06:38:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 06:38:45]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[lushnikov, 2017-01-26 08:35:49]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2017-01-26 08:35:49]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2652153003/#ps20001
(title: "rebaseline")

[commit-bot: I haz the power, 2017-01-26 08:36:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 10:06:57]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485419749624010,
"parent_rev": "6d6be5f4ecb81eaf2b60ad6ff33ac3ded0514af8", "commit_rev":
"73df3267dc9ccbbfe1cde0f25e013e2c96c14f41"}

[commit-bot: I haz the power, 2017-01-26 10:07:27]

Description was changed from

==========
DevTools: migrate SoftContextMenu icons over to UI.Icon

This patch migrates the checkmark icon in the SoftContextMenu over to
the UI.Icon.

BUG=669323
R=dgozman
==========

to

==========
DevTools: migrate SoftContextMenu icons over to UI.Icon

This patch migrates the checkmark icon in the SoftContextMenu over to
the UI.Icon.

BUG=669323
R=dgozman

Review-Url: https://codereview.chromium.org/2652153003
Cr-Commit-Position: refs/heads/master@{#446291}
Committed:
https://chromium.googlesource.com/chromium/src/+/73df3267dc9ccbbfe1cde0f25e01...
==========

[commit-bot: I haz the power, 2017-01-26 10:07:28]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/73df3267dc9ccbbfe1cde0f25e01...