Convert UberUI to use the new navigation callbacks.

Convert UberUI to use the new navigation callbacks.

BUG=682002
Review-Url: https://codereview.chromium.org/2651793009
Cr-Commit-Position: refs/heads/master@{#446510}
Committed: https://chromium.googlesource.com/chromium/src/+/690788219fba7c2b19f023793e352f8303139be7

[jam, 2017-01-26 22:09:32]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 22:10:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 22:59:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 22:59:43]

Dry run: This issue passed the CQ dry run.

[jam, 2017-01-26 23:04:11]

jam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2017-01-26 23:43:44]

interesting subtle differences between all these webui navigation observing CLs
you've sent me.

seems legit

lgtm

[jam, 2017-01-27 00:02:31]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-01-27 00:04:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-01-27 00:04:53]

Yeah there are differences in behavior between
DidStartProvisionalLoadForFrame/DidStartNavigation (previous cls) and
DidCommitProvisionalLoadForFrame/DidFinishNavigation.
DidStartProvisionalLoadForFrame isn't called for same page navigations while
DidStartNavigation is. DidCommitProvisionalLoadForFrame is (confusingly) called
for same page navigations. Hopefully the new API is clearer and more consistent.
The old ones should be removed very shortly.

On 2017/01/26 23:43:44, Dan Beam wrote:
> interesting subtle differences between all these webui navigation observing
CLs
> you've sent me.
> 
> seems legit
> 
> lgtm

[jam, 2017-01-27 00:37:39]

The CQ bit was unchecked by jam@chromium.org

[jam, 2017-01-27 00:37:44]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-01-27 00:38:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 01:00:02]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485477464598490, "parent_rev":
"9f4490a30641dcd7710ffca2fd7ff0a3aaad978a", "commit_rev":
"690788219fba7c2b19f023793e352f8303139be7"}

[commit-bot: I haz the power, 2017-01-27 01:00:36]

Description was changed from

==========
Convert UberUI to use the new navigation callbacks.

BUG=682002
==========

to

==========
Convert UberUI to use the new navigation callbacks.

BUG=682002

Review-Url: https://codereview.chromium.org/2651793009
Cr-Commit-Position: refs/heads/master@{#446510}
Committed:
https://chromium.googlesource.com/chromium/src/+/690788219fba7c2b19f023793e35...
==========

[commit-bot: I haz the power, 2017-01-27 01:00:37]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/690788219fba7c2b19f023793e35...