chrome/browser/ui/webui/uber/uber_ui.h - Issue 2651793009: Convert UberUI to use the new navigation callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/uber/uber_ui.h

Issue 2651793009: Convert UberUI to use the new navigation callbacks. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/uber/uber_ui.h

diff --git a/chrome/browser/ui/webui/uber/uber_ui.h b/chrome/browser/ui/webui/uber/uber_ui.h

index 701df519461ae5cff39e5ffaa3cd878469e983c0..f041585169565b32e5f98ad5cf577e99431e59c4 100644

--- a/chrome/browser/ui/webui/uber/uber_ui.h

+++ b/chrome/browser/ui/webui/uber/uber_ui.h

@@ -29,10 +29,8 @@ class SubframeLogger : public content::WebContentsObserver {

~SubframeLogger() override;

// content::WebContentsObserver implementation.

- void DidCommitProvisionalLoadForFrame(

- content::RenderFrameHost* render_frame_host,

- const GURL& url,

- ui::PageTransition transition_type) override;

+ void DidFinishNavigation(

+ content::NavigationHandle* navigation_handle) override;

private:

DISALLOW_COPY_AND_ASSIGN(SubframeLogger);

« no previous file with comments | « no previous file | chrome/browser/ui/webui/uber/uber_ui.cc » ('j') | no next file with comments »