Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Side by Side Diff: chrome/browser/ui/webui/uber/uber_ui.h

Issue 2651793009: Convert UberUI to use the new navigation callbacks. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/uber/uber_ui.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_UBER_UBER_UI_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_UBER_UBER_UI_H_
6 #define CHROME_BROWSER_UI_WEBUI_UBER_UBER_UI_H_ 6 #define CHROME_BROWSER_UI_WEBUI_UBER_UBER_UI_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 11 matching lines...) Expand all
22 class ExtensionRegistry; 22 class ExtensionRegistry;
23 } 23 }
24 24
25 // Logs visits to subframe URLs (e.g. chrome://settings-frame). 25 // Logs visits to subframe URLs (e.g. chrome://settings-frame).
26 class SubframeLogger : public content::WebContentsObserver { 26 class SubframeLogger : public content::WebContentsObserver {
27 public: 27 public:
28 explicit SubframeLogger(content::WebContents* contents); 28 explicit SubframeLogger(content::WebContents* contents);
29 ~SubframeLogger() override; 29 ~SubframeLogger() override;
30 30
31 // content::WebContentsObserver implementation. 31 // content::WebContentsObserver implementation.
32 void DidCommitProvisionalLoadForFrame( 32 void DidFinishNavigation(
33 content::RenderFrameHost* render_frame_host, 33 content::NavigationHandle* navigation_handle) override;
34 const GURL& url,
35 ui::PageTransition transition_type) override;
36 34
37 private: 35 private:
38 DISALLOW_COPY_AND_ASSIGN(SubframeLogger); 36 DISALLOW_COPY_AND_ASSIGN(SubframeLogger);
39 }; 37 };
40 38
41 // The WebUI class for the uber page (chrome://chrome). It manages the UI for 39 // The WebUI class for the uber page (chrome://chrome). It manages the UI for
42 // the uber page (navigation bar and so forth) as well as WebUI objects for 40 // the uber page (navigation bar and so forth) as well as WebUI objects for
43 // pages that appear in the uber page. 41 // pages that appear in the uber page.
44 class UberUI : public content::WebUIController { 42 class UberUI : public content::WebUIController {
45 public: 43 public:
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 extensions::UnloadedExtensionInfo::Reason reason) override; 83 extensions::UnloadedExtensionInfo::Reason reason) override;
86 84
87 ScopedObserver<extensions::ExtensionRegistry, 85 ScopedObserver<extensions::ExtensionRegistry,
88 extensions::ExtensionRegistryObserver> 86 extensions::ExtensionRegistryObserver>
89 extension_registry_observer_; 87 extension_registry_observer_;
90 88
91 DISALLOW_COPY_AND_ASSIGN(UberFrameUI); 89 DISALLOW_COPY_AND_ASSIGN(UberFrameUI);
92 }; 90 };
93 91
94 #endif // CHROME_BROWSER_UI_WEBUI_UBER_UBER_UI_H_ 92 #endif // CHROME_BROWSER_UI_WEBUI_UBER_UBER_UI_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/webui/uber/uber_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698