Use a new Supplement constructor for ServiceWorkerRegistration supplements

Use a new Supplement constructor for ServiceWorkerRegistration supplements

This is a step to deprecate the default constructor of Supplement<>.
Also this CL removes Member<ServiceWorkerRegistration>.

BUG=610176
Review-Url: https://codereview.chromium.org/2651613002
Cr-Commit-Position: refs/heads/master@{#448582}
Committed: https://chromium.googlesource.com/chromium/src/+/73d601815cebdd38fc5248d62ed884477c9e0972

[haraken, 2017-01-23 08:50:14]

The CQ bit was checked by haraken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 08:50:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-01-23 08:50:25]

haraken@chromium.org changed reviewers:
+ sigbjornf@opera.com

[haraken, 2017-01-23 08:50:26]

PTAL

[sof, 2017-01-23 08:54:16]

lgtm, supplementable() access pays off here.

[haraken, 2017-01-23 09:04:00]

The CQ bit was unchecked by haraken@chromium.org

[haraken, 2017-01-23 09:04:06]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2017-01-23 09:04:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 11:23:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 11:24:00]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[haraken, 2017-01-23 11:24:31]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2017-01-23 11:24:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 12:35:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 12:35:11]

Failed to apply patch for
third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp:12
  error:
third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp:
patch does not apply

Patch:      
third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp
Index:
third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp
diff --git
a/third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp
b/third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp
index
73160f042ade6669ce253c8138413baca46ac274..cf1cc10cf36c6a05af88fe322b6e82c2a13d122c
100644
---
a/third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp
+++
b/third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp
@@ -12,7 +12,8 @@
 
 namespace blink {
 
-NavigatorServiceWorker::NavigatorServiceWorker(Navigator& navigator) {}
+NavigatorServiceWorker::NavigatorServiceWorker(Navigator& navigator)
+    : Supplement<Navigator>(navigator) {}
 
 NavigatorServiceWorker* NavigatorServiceWorker::from(Document& document) {
   if (!document.frame() || !document.frame()->domWindow())

[haraken, 2017-02-07 08:58:02]

The CQ bit was checked by haraken@chromium.org

[haraken, 2017-02-07 08:58:02]

The patchset sent to the CQ was uploaded after l-g-t-m from sigbjornf@opera.com
Link to the patchset: https://codereview.chromium.org/2651613002/#ps20001
(title: "temp")

[commit-bot: I haz the power, 2017-02-07 08:58:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 10:28:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486457882027450,
"parent_rev": "70957b2671edd5d21ec7b8a6cd36c0cc1f92df99", "commit_rev":
"73d601815cebdd38fc5248d62ed884477c9e0972"}

[commit-bot: I haz the power, 2017-02-07 10:29:11]

Description was changed from

==========
Use a new Supplement constructor for ServiceWorkerRegistration supplements

This is a step to deprecate the default constructor of Supplement<>.
Also this CL removes Member<ServiceWorkerRegistration>.

BUG=610176
==========

to

==========
Use a new Supplement constructor for ServiceWorkerRegistration supplements

This is a step to deprecate the default constructor of Supplement<>.
Also this CL removes Member<ServiceWorkerRegistration>.

BUG=610176

Review-Url: https://codereview.chromium.org/2651613002
Cr-Commit-Position: refs/heads/master@{#448582}
Committed:
https://chromium.googlesource.com/chromium/src/+/73d601815cebdd38fc5248d62ed8...
==========

[commit-bot: I haz the power, 2017-02-07 10:29:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/73d601815cebdd38fc5248d62ed8...

[shimazu, 2017-02-08 05:08:22]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2686613004/ by shimazu@chromium.org.

The reason for reverting is: This seems causing test failures on Leak bot:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty...

6 tests failed:
fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html
( Code Search )
fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html
( Code Search )
fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html (
Code Search )
fast/dom/Window/property-access-on-cached-window-after-frame-navigated.html (
Code Search )
fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced.html
( Code Search )
fast/dom/Window/property-access-on-cached-window-after-frame-removed.html ( Code
Search ).