third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.h - Issue 2651613002: Use a new Supplement constructor for ServiceWorkerRegistration supplements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.h

Issue 2651613002: Use a new Supplement constructor for ServiceWorkerRegistration supplements (Closed)

Patch Set: temp Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/background_sync/ServiceWorkerRegistrationSync.cpp ('k') | third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.h

diff --git a/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.h b/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.h

index fdf4d09c87ef9eb23794510ef4a26527505f37c8..8645acd8b47b883c06097cfd469b0b5e7ec9e606 100644

--- a/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.h

+++ b/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.h

@@ -52,8 +52,8 @@ class ServiceWorkerRegistrationNotifications final

DECLARE_VIRTUAL_TRACE();

private:

- ServiceWorkerRegistrationNotifications(ExecutionContext*,

- ServiceWorkerRegistration*);

+ ServiceWorkerRegistrationNotifications(ServiceWorkerRegistration&,

+ ExecutionContext*);

static const char* supplementName();

static ServiceWorkerRegistrationNotifications& from(

@@ -67,7 +67,6 @@ class ServiceWorkerRegistrationNotifications final

std::unique_ptr<WebNotificationShowCallbacks>,

NotificationResourcesLoader*);

- Member<ServiceWorkerRegistration> m_registration;

HeapHashSet<Member<NotificationResourcesLoader>> m_loaders;

};