third_party/WebKit/Source/modules/push_messaging/ServiceWorkerRegistrationPush.h - Issue 2651613002: Use a new Supplement constructor for ServiceWorkerRegistration supplements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/push_messaging/ServiceWorkerRegistrationPush.h

Issue 2651613002: Use a new Supplement constructor for ServiceWorkerRegistration supplements (Closed)

Patch Set: temp Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/payments/PaymentAppServiceWorkerRegistration.cpp ('k') | third_party/WebKit/Source/modules/push_messaging/ServiceWorkerRegistrationPush.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/push_messaging/ServiceWorkerRegistrationPush.h

diff --git a/third_party/WebKit/Source/modules/push_messaging/ServiceWorkerRegistrationPush.h b/third_party/WebKit/Source/modules/push_messaging/ServiceWorkerRegistrationPush.h

index 343581ec8bc8fe51b52bd2419d59f1744dea8285..3d0f4405c90aaad9ff4282c50b1d68f337171a48 100644

--- a/third_party/WebKit/Source/modules/push_messaging/ServiceWorkerRegistrationPush.h

+++ b/third_party/WebKit/Source/modules/push_messaging/ServiceWorkerRegistrationPush.h

@@ -30,10 +30,9 @@ class ServiceWorkerRegistrationPush final

DECLARE_VIRTUAL_TRACE();

private:

- explicit ServiceWorkerRegistrationPush(ServiceWorkerRegistration*);

+ explicit ServiceWorkerRegistrationPush(ServiceWorkerRegistration&);

static const char* supplementName();

- Member<ServiceWorkerRegistration> m_registration;

Member<PushManager> m_pushManager;

};