Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(331)

Issue 2651593002: mus: Remove the old client lib. (Closed)

Created:
10 months, 4 weeks ago by sadrul
Modified:
10 months, 4 weeks ago
Reviewers:
Fady Samuel, jam, sky
CC:
chromium-reviews, rjkroege, mlamouri+watch-content_chromium.org, sadrul, Ian Vollick, jam, dcheng, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus: Remove the old client lib. Remove the code for chrome-renderer that uses the old client-lib for mus. Remove the old client-lib for mus since that is the only remaining use. A subsequent CL will add a thin client-lib for chrome-renderer to use when it runs as a mus-client (i.e. chrome is run with --use-mus-in-renderer). BUG=672913 TBR=jam@ gpu_process_transport_factory.cc and render_widget.cc (trivial code update for deleted code) Review-Url: https://codereview.chromium.org/2651593002 Cr-Commit-Position: refs/heads/master@{#445423} Committed: https://chromium.googlesource.com/chromium/src/+/9fe4892d60cfb278970d6acb517e581a241ab012

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 2

Patch Set 4 : restore test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -9027 lines) Patch
M ash/mus/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 1 chunk +7 lines, -18 lines 0 comments Download
M content/browser/compositor/mus_browser_compositor_output_surface.h View 3 chunks +0 lines, -20 lines 0 comments Download
M content/browser/compositor/mus_browser_compositor_output_surface.cc View 5 chunks +2 lines, -32 lines 0 comments Download
M content/renderer/mus/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D content/renderer/mus/compositor_mus_connection.h View 1 chunk +0 lines, -124 lines 0 comments Download
D content/renderer/mus/compositor_mus_connection.cc View 1 chunk +0 lines, -237 lines 0 comments Download
D content/renderer/mus/compositor_mus_connection_unittest.cc View 1 chunk +0 lines, -502 lines 0 comments Download
M content/renderer/mus/render_widget_mus_connection.h View 2 chunks +9 lines, -35 lines 0 comments Download
M content/renderer/mus/render_widget_mus_connection.cc View 4 chunks +4 lines, -119 lines 0 comments Download
M content/renderer/render_widget.cc View 2 chunks +1 line, -18 lines 0 comments Download
M content/test/BUILD.gn View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M services/ui/public/cpp/BUILD.gn View 4 chunks +1 line, -45 lines 0 comments Download
D services/ui/public/cpp/in_flight_change.h View 1 chunk +0 lines, -312 lines 0 comments Download
D services/ui/public/cpp/in_flight_change.cc View 1 chunk +0 lines, -231 lines 0 comments Download
D services/ui/public/cpp/input_event_handler.h View 1 chunk +0 lines, -43 lines 0 comments Download
D services/ui/public/cpp/scoped_window_ptr.h View 1 chunk +0 lines, -42 lines 0 comments Download
D services/ui/public/cpp/scoped_window_ptr.cc View 1 chunk +0 lines, -44 lines 0 comments Download
D services/ui/public/cpp/tests/BUILD.gn View 1 2 3 1 chunk +0 lines, -32 lines 0 comments Download
D services/ui/public/cpp/tests/test_window.h View 1 chunk +0 lines, -29 lines 0 comments Download
D services/ui/public/cpp/tests/test_window_tree.h View 1 chunk +0 lines, -134 lines 0 comments Download
D services/ui/public/cpp/tests/test_window_tree.cc View 1 chunk +0 lines, -194 lines 0 comments Download
D services/ui/public/cpp/tests/test_window_tree_client_setup.h View 1 chunk +0 lines, -53 lines 0 comments Download
D services/ui/public/cpp/tests/test_window_tree_client_setup.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D services/ui/public/cpp/tests/window_tree_client_private.h View 1 chunk +0 lines, -63 lines 0 comments Download
D services/ui/public/cpp/tests/window_tree_client_private.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D services/ui/public/cpp/tests/window_tree_client_unittest.cc View 1 chunk +0 lines, -1090 lines 0 comments Download
D services/ui/public/cpp/tests/window_unittest.cc View 1 chunk +0 lines, -1265 lines 0 comments Download
D services/ui/public/cpp/window.h View 1 chunk +0 lines, -406 lines 0 comments Download
D services/ui/public/cpp/window.cc View 1 chunk +0 lines, -965 lines 0 comments Download
D services/ui/public/cpp/window_drop_target.h View 1 chunk +0 lines, -65 lines 0 comments Download
D services/ui/public/cpp/window_manager_delegate.h View 1 chunk +0 lines, -130 lines 0 comments Download
D services/ui/public/cpp/window_manager_delegate.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D services/ui/public/cpp/window_observer.h View 1 chunk +0 lines, -135 lines 0 comments Download
D services/ui/public/cpp/window_observer.cc View 1 chunk +0 lines, -18 lines 0 comments Download
D services/ui/public/cpp/window_private.h View 1 chunk +0 lines, -101 lines 0 comments Download
D services/ui/public/cpp/window_private.cc View 1 chunk +0 lines, -20 lines 0 comments Download
D services/ui/public/cpp/window_property.h View 1 chunk +0 lines, -156 lines 0 comments Download
D services/ui/public/cpp/window_tracker.h View 1 chunk +0 lines, -21 lines 0 comments Download
D services/ui/public/cpp/window_tree_client.h View 1 chunk +0 lines, -494 lines 0 comments Download
D services/ui/public/cpp/window_tree_client.cc View 1 chunk +0 lines, -1482 lines 0 comments Download
D services/ui/public/cpp/window_tree_client_delegate.h View 1 chunk +0 lines, -57 lines 0 comments Download
D services/ui/public/cpp/window_tree_client_delegate.cc View 1 chunk +0 lines, -11 lines 0 comments Download
D services/ui/public/cpp/window_tree_client_observer.h View 1 chunk +0 lines, -35 lines 0 comments Download
D services/ui/public/cpp/window_tree_host_factory.h View 1 chunk +0 lines, -40 lines 0 comments Download
D services/ui/public/cpp/window_tree_host_factory.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M services/ui/ws/BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/compositor.h View 3 chunks +0 lines, -13 lines 0 comments Download
M ui/compositor/compositor.cc View 2 chunks +0 lines, -13 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 29 (20 generated)
sadrul
10 months, 4 weeks ago (2017-01-23 07:16:57 UTC) #4
sky
One question, everything else looks good. https://codereview.chromium.org/2651593002/diff/40001/services/ui/public/cpp/tests/property_type_converters_unittest.cc File services/ui/public/cpp/tests/property_type_converters_unittest.cc (left): https://codereview.chromium.org/2651593002/diff/40001/services/ui/public/cpp/tests/property_type_converters_unittest.cc#oldcode15 services/ui/public/cpp/tests/property_type_converters_unittest.cc:15: TEST(PropertyTypeConvertersTest, SkBitmapRoundTrip) { ...
10 months, 4 weeks ago (2017-01-23 16:42:38 UTC) #13
Fady Samuel
drive-by w00t!
10 months, 4 weeks ago (2017-01-23 16:43:36 UTC) #15
sadrul
https://codereview.chromium.org/2651593002/diff/40001/services/ui/public/cpp/tests/property_type_converters_unittest.cc File services/ui/public/cpp/tests/property_type_converters_unittest.cc (left): https://codereview.chromium.org/2651593002/diff/40001/services/ui/public/cpp/tests/property_type_converters_unittest.cc#oldcode15 services/ui/public/cpp/tests/property_type_converters_unittest.cc:15: TEST(PropertyTypeConvertersTest, SkBitmapRoundTrip) { On 2017/01/23 16:42:38, sky wrote: > ...
10 months, 4 weeks ago (2017-01-23 17:40:09 UTC) #18
sky
On 2017/01/23 17:40:09, sadrul wrote: > https://codereview.chromium.org/2651593002/diff/40001/services/ui/public/cpp/tests/property_type_converters_unittest.cc > File services/ui/public/cpp/tests/property_type_converters_unittest.cc (left): > > https://codereview.chromium.org/2651593002/diff/40001/services/ui/public/cpp/tests/property_type_converters_unittest.cc#oldcode15 > ...
10 months, 4 weeks ago (2017-01-23 17:43:57 UTC) #19
sadrul
+avi@chromium.org for owner review of content/browser/compositor/gpu_process_transport_factory.cc and content/renderer/render_widget.cc (both are trivial changes to update for ...
10 months, 4 weeks ago (2017-01-23 18:08:14 UTC) #21
sadrul
+jam@ gpu_process_transport_factory.cc and render_widget.cc since avi@ is ooo (will TBR since trivial code update for ...
10 months, 4 weeks ago (2017-01-23 18:51:44 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651593002/60001
10 months, 4 weeks ago (2017-01-23 18:54:11 UTC) #26
commit-bot: I haz the power
10 months, 4 weeks ago (2017-01-23 19:00:31 UTC) #29
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9fe4892d60cfb278970d6acb517e...

Powered by Google App Engine
This is Rietveld 0eb02b776