mus: Remove the old client lib.

mus: Remove the old client lib.

Remove the code for chrome-renderer that uses the old client-lib for mus.
Remove the old client-lib for mus since that is the only remaining use. A
subsequent CL will add a thin client-lib for chrome-renderer to use when
it runs as a mus-client (i.e. chrome is run with --use-mus-in-renderer).

BUG=672913
TBR=jam@ gpu_process_transport_factory.cc and render_widget.cc
    (trivial code update for deleted code)

Review-Url: https://codereview.chromium.org/2651593002
Cr-Commit-Position: refs/heads/master@{#445423}
Committed: https://chromium.googlesource.com/chromium/src/+/9fe4892d60cfb278970d6acb517e581a241ab012

[sadrul, 2017-01-23 07:10:24]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 07:10:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-01-23 07:16:56]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org

[sadrul, 2017-01-23 07:21:36]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 07:21:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 07:32:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 07:32:49]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[sadrul, 2017-01-23 07:34:02]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 07:34:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 08:27:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 08:27:03]

Dry run: This issue passed the CQ dry run.

[sky, 2017-01-23 16:42:38]

One question, everything else looks good.

https://codereview.chromium.org/2651593002/diff/40001/services/ui/public/cpp/...
File services/ui/public/cpp/tests/property_type_converters_unittest.cc (left):

https://codereview.chromium.org/2651593002/diff/40001/services/ui/public/cpp/...
services/ui/public/cpp/tests/property_type_converters_unittest.cc:15:
TEST(PropertyTypeConvertersTest, SkBitmapRoundTrip) {
Aren't we still using property type converter?

[Fady Samuel, 2017-01-23 16:43:35]

fsamuel@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2017-01-23 16:43:36]

drive-by w00t!

[sadrul, 2017-01-23 17:39:05]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 17:39:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-01-23 17:40:09]

https://codereview.chromium.org/2651593002/diff/40001/services/ui/public/cpp/...
File services/ui/public/cpp/tests/property_type_converters_unittest.cc (left):

https://codereview.chromium.org/2651593002/diff/40001/services/ui/public/cpp/...
services/ui/public/cpp/tests/property_type_converters_unittest.cc:15:
TEST(PropertyTypeConvertersTest, SkBitmapRoundTrip) {
On 2017/01/23 16:42:38, sky wrote:
> Aren't we still using property type converter?

Good catch! Restored this.

Although, would it make sense to merge this with the prop-converter in aura-mus?

[sky, 2017-01-23 17:43:57]

On 2017/01/23 17:40:09, sadrul wrote:
>
https://codereview.chromium.org/2651593002/diff/40001/services/ui/public/cpp/...
> File services/ui/public/cpp/tests/property_type_converters_unittest.cc (left):
> 
>
https://codereview.chromium.org/2651593002/diff/40001/services/ui/public/cpp/...
> services/ui/public/cpp/tests/property_type_converters_unittest.cc:15:
> TEST(PropertyTypeConvertersTest, SkBitmapRoundTrip) {
> On 2017/01/23 16:42:38, sky wrote:
> > Aren't we still using property type converter?
> 
> Good catch! Restored this.
> 
> Although, would it make sense to merge this with the prop-converter in
aura-mus?

Long term we want aura to move to services/ui/public/cpp. OTOH having the code
split feels awkward right now. I think we should move all the client lib related
code to aura-mus for the time being, and then move back to
services/ui/public/cpp when ready. Don't do that here though. LGTM

[sadrul, 2017-01-23 18:08:13]

sadrul@chromium.org changed reviewers:
+ avi@chromium.org

[sadrul, 2017-01-23 18:08:14]

+avi@chromium.org for owner review of 
content/browser/compositor/gpu_process_transport_factory.cc and
content/renderer/render_widget.cc (both are trivial changes to update for
deleted code, so will TBR if trybots are happy)

[sadrul, 2017-01-23 18:51:43]

sadrul@chromium.org changed reviewers:
+ jam@chromium.org
- avi@chromium.org

[sadrul, 2017-01-23 18:51:44]

+jam@ gpu_process_transport_factory.cc and render_widget.cc since avi@ is ooo
(will TBR since trivial code update for deleted code)

[sadrul, 2017-01-23 18:52:30]

Description was changed from

==========
mus: Remove the old client lib.

Remove the code for chrome-renderer that uses the old client-lib for mus.
Remove the old client-lib for mus since that is the only remaining use. A
subsequent CL will add a thin client-lib for chrome-renderer to use when
it runs as a mus-client (i.e. chrome is run with --use-mus-in-renderer).

BUG=672913
==========

to

==========
mus: Remove the old client lib.

Remove the code for chrome-renderer that uses the old client-lib for mus.
Remove the old client-lib for mus since that is the only remaining use. A
subsequent CL will add a thin client-lib for chrome-renderer to use when
it runs as a mus-client (i.e. chrome is run with --use-mus-in-renderer).

BUG=672913
TBR=jam@ gpu_process_transport_factory.cc and render_widget.cc
    (trivial code update for deleted code)
==========

[sadrul, 2017-01-23 18:53:47]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2017-01-23 18:54:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 18:59:53]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485197627718720,
"parent_rev": "786d091820e90bf779df0f724a4d7f08a8a99f88", "commit_rev":
"9fe4892d60cfb278970d6acb517e581a241ab012"}

[commit-bot: I haz the power, 2017-01-23 19:00:30]

Description was changed from

==========
mus: Remove the old client lib.

Remove the code for chrome-renderer that uses the old client-lib for mus.
Remove the old client-lib for mus since that is the only remaining use. A
subsequent CL will add a thin client-lib for chrome-renderer to use when
it runs as a mus-client (i.e. chrome is run with --use-mus-in-renderer).

BUG=672913
TBR=jam@ gpu_process_transport_factory.cc and render_widget.cc
    (trivial code update for deleted code)
==========

to

==========
mus: Remove the old client lib.

Remove the code for chrome-renderer that uses the old client-lib for mus.
Remove the old client-lib for mus since that is the only remaining use. A
subsequent CL will add a thin client-lib for chrome-renderer to use when
it runs as a mus-client (i.e. chrome is run with --use-mus-in-renderer).

BUG=672913
TBR=jam@ gpu_process_transport_factory.cc and render_widget.cc
    (trivial code update for deleted code)

Review-Url: https://codereview.chromium.org/2651593002
Cr-Commit-Position: refs/heads/master@{#445423}
Committed:
https://chromium.googlesource.com/chromium/src/+/9fe4892d60cfb278970d6acb517e...
==========

[commit-bot: I haz the power, 2017-01-23 19:00:31]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9fe4892d60cfb278970d6acb517e...