Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(396)

Issue 2647363002: mus: Remove aura version of WindowCompositorFrameSink. (Closed)

Created:
10 months, 3 weeks ago by sadrul
Modified:
10 months, 3 weeks ago
Reviewers:
Fady Samuel, sky
CC:
chromium-reviews, rjkroege, sadrul, jam, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus: Remove aura version of WindowCompositorFrameSink. The two versions of WindowCompositorFrameSink, in aura-mus, and in the old client-lib, are identical. Remove the version in aura-mus, and retain the one from the old client-lib. This allows its use from chrome-renderer without pulling in the rest of aura. BUG=672913 Review-Url: https://codereview.chromium.org/2647363002 Cr-Commit-Position: refs/heads/master@{#445472} Committed: https://chromium.googlesource.com/chromium/src/+/dc25423dd85608261051a18d0f45224d70228d12

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : tot merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -260 lines) Patch
M content/browser/compositor/mus_browser_compositor_output_surface.h View 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/compositor/mus_browser_compositor_output_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/public/cpp/window_compositor_frame_sink.h View 3 chunks +4 lines, -4 lines 0 comments Download
M services/ui/public/cpp/window_compositor_frame_sink.cc View 1 3 chunks +12 lines, -4 lines 0 comments Download
M ui/aura/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/aura/mus/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
D ui/aura/mus/window_compositor_frame_sink.h View 1 chunk +0 lines, -100 lines 0 comments Download
D ui/aura/mus/window_compositor_frame_sink.cc View 1 chunk +0 lines, -135 lines 0 comments Download
M ui/aura/mus/window_port_mus.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/aura/mus/window_port_mus.cc View 2 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
sadrul
Instead of keeping the older version of WindowCompositorFrameSink (so that chrome-renderer can use it without ...
10 months, 3 weeks ago (2017-01-23 18:05:12 UTC) #4
Fady Samuel
I'm happy with this. LGTM
10 months, 3 weeks ago (2017-01-23 18:09:13 UTC) #9
sky
LGTM
10 months, 3 weeks ago (2017-01-23 20:08:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2647363002/40001
10 months, 3 weeks ago (2017-01-23 20:10:52 UTC) #15
commit-bot: I haz the power
10 months, 3 weeks ago (2017-01-23 20:39:45 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/dc25423dd85608261051a18d0f45...

Powered by Google App Engine
This is Rietveld 0eb02b776