Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2650873002: Refactor PaintLayer location and offset calculation especially for floats (Closed)

Created:
3 years, 11 months ago by Xianzhu
Modified:
3 years, 10 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor PaintLayer location and offset calculation especially for floats This is a follow-up of https://codereview.chromium.org/2647383004/ to cleanup the logic. Add PaintLayer::containingLayer() (based on the previous containgLayerForOutOfFlowPositioned()) to return the containing layer for any layer and use it during location and offset calculation. BTW, this also fixes a hidden bug about layer location of float and multicol spanner in scrolled containing block which is not the parent layer. BUG=683576 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2650873002 Cr-Commit-Position: refs/heads/master@{#446568} Committed: https://chromium.googlesource.com/chromium/src/+/d8e6e751f1e8982648cb06bf74889544a5733d04

Patch Set 1 #

Patch Set 2 : Refactor PaintLayer location and offset calculation #

Patch Set 3 : - #

Total comments: 5

Patch Set 4 : Test the bug fixed BTW #

Total comments: 2

Patch Set 5 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -108 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 2 3 4 1 chunk +14 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp View 1 2 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp View 1 2 1 chunk +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.cpp View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.h View 1 2 3 4 2 chunks +10 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 2 3 4 5 chunks +49 lines, -77 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerTest.cpp View 1 2 3 4 4 chunks +73 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (15 generated)
Xianzhu
3 years, 11 months ago (2017-01-24 17:30:16 UTC) #7
chrishtr
https://codereview.chromium.org/2650873002/diff/40001/third_party/WebKit/Source/core/paint/PaintLayer.cpp File third_party/WebKit/Source/core/paint/PaintLayer.cpp (right): https://codereview.chromium.org/2650873002/diff/40001/third_party/WebKit/Source/core/paint/PaintLayer.cpp#newcode872 third_party/WebKit/Source/core/paint/PaintLayer.cpp:872: LayoutObject* layoutObject = this->layoutObject(); Are the changes here just ...
3 years, 11 months ago (2017-01-25 21:06:40 UTC) #11
Xianzhu
https://codereview.chromium.org/2650873002/diff/40001/third_party/WebKit/Source/core/paint/PaintLayer.cpp File third_party/WebKit/Source/core/paint/PaintLayer.cpp (right): https://codereview.chromium.org/2650873002/diff/40001/third_party/WebKit/Source/core/paint/PaintLayer.cpp#newcode872 third_party/WebKit/Source/core/paint/PaintLayer.cpp:872: LayoutObject* layoutObject = this->layoutObject(); On 2017/01/25 21:06:40, chrishtr wrote: ...
3 years, 11 months ago (2017-01-25 22:03:00 UTC) #12
Xianzhu
https://codereview.chromium.org/2650873002/diff/40001/third_party/WebKit/Source/core/paint/PaintLayer.h File third_party/WebKit/Source/core/paint/PaintLayer.h (right): https://codereview.chromium.org/2650873002/diff/40001/third_party/WebKit/Source/core/paint/PaintLayer.h#newcode344 third_party/WebKit/Source/core/paint/PaintLayer.h:344: // parent layer might not be the containing block. ...
3 years, 11 months ago (2017-01-25 22:14:10 UTC) #13
Xianzhu
On 2017/01/25 22:03:00, Xianzhu wrote: > https://codereview.chromium.org/2650873002/diff/40001/third_party/WebKit/Source/core/paint/PaintLayer.cpp > File third_party/WebKit/Source/core/paint/PaintLayer.cpp (right): > > https://codereview.chromium.org/2650873002/diff/40001/third_party/WebKit/Source/core/paint/PaintLayer.cpp#newcode872 > ...
3 years, 11 months ago (2017-01-25 23:34:32 UTC) #15
chrishtr
https://codereview.chromium.org/2650873002/diff/40001/third_party/WebKit/Source/core/paint/PaintLayer.h File third_party/WebKit/Source/core/paint/PaintLayer.h (right): https://codereview.chromium.org/2650873002/diff/40001/third_party/WebKit/Source/core/paint/PaintLayer.h#newcode344 third_party/WebKit/Source/core/paint/PaintLayer.h:344: // parent layer might not be the containing block. ...
3 years, 11 months ago (2017-01-27 00:36:22 UTC) #16
chrishtr
lgtm https://codereview.chromium.org/2650873002/diff/60001/third_party/WebKit/Source/core/paint/PaintLayerTest.cpp File third_party/WebKit/Source/core/paint/PaintLayerTest.cpp (right): https://codereview.chromium.org/2650873002/diff/60001/third_party/WebKit/Source/core/paint/PaintLayerTest.cpp#newcode604 third_party/WebKit/Source/core/paint/PaintLayerTest.cpp:604: TEST_P(PaintLayerTest, ColomnSpanLayerUnderExtraLayerScrolled) { nit: Column
3 years, 11 months ago (2017-01-27 01:00:06 UTC) #17
Xianzhu
https://codereview.chromium.org/2650873002/diff/60001/third_party/WebKit/Source/core/paint/PaintLayerTest.cpp File third_party/WebKit/Source/core/paint/PaintLayerTest.cpp (right): https://codereview.chromium.org/2650873002/diff/60001/third_party/WebKit/Source/core/paint/PaintLayerTest.cpp#newcode604 third_party/WebKit/Source/core/paint/PaintLayerTest.cpp:604: TEST_P(PaintLayerTest, ColomnSpanLayerUnderExtraLayerScrolled) { On 2017/01/27 01:00:06, chrishtr wrote: > ...
3 years, 11 months ago (2017-01-27 01:22:20 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650873002/80001
3 years, 11 months ago (2017-01-27 01:23:41 UTC) #22
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 03:23:49 UTC) #25
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/d8e6e751f1e8982648cb06bf7488...

Powered by Google App Engine
This is Rietveld 408576698