Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp

Issue 2650873002: Refactor PaintLayer location and offset calculation especially for floats (Closed)
Patch Set: - Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2009, 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2014 Google Inc. All rights reserved. 3 * Copyright (C) 2014 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 CompositingState compositingState = layer.compositingState(); 47 CompositingState compositingState = layer.compositingState();
48 if (compositingState != NotComposited && 48 if (compositingState != NotComposited &&
49 compositingState != PaintsIntoGroupedBacking) { 49 compositingState != PaintsIntoGroupedBacking) {
50 m_compositingAncestor = &layer; 50 m_compositingAncestor = &layer;
51 if (layer.stackingNode()->isStackingContext()) 51 if (layer.stackingNode()->isStackingContext())
52 m_compositingStackingContext = &layer; 52 m_compositingStackingContext = &layer;
53 } 53 }
54 } 54 }
55 55
56 const PaintLayer* compositingContainer(const PaintLayer& layer) const { 56 const PaintLayer* compositingContainer(const PaintLayer& layer) const {
57 // TODO(chrishtr) this is not very performant for floats, but they should 57 if (layer.stackingNode()->isStacked())
58 // be uncommon enough, and SPv2 will remove this code. 58 return m_compositingStackingContext;
59 if (layer.layoutObject()->isFloating() && layer.layoutObject()->parent() && 59
60 !layer.stackingNode()->isStacked() && 60 if (layer.layoutObject()->isFloatingWithNonContainingBlockParent())
61 !layer.layoutObject()->parent()->isLayoutBlockFlow()) {
62 return layer.enclosingLayerWithCompositedLayerMapping(ExcludeSelf); 61 return layer.enclosingLayerWithCompositedLayerMapping(ExcludeSelf);
63 } 62
64 return layer.stackingNode()->isStacked() ? m_compositingStackingContext 63 return m_compositingAncestor;
65 : m_compositingAncestor;
66 } 64 }
67 65
68 const PaintLayer* compositingStackingContext() const { 66 const PaintLayer* compositingStackingContext() const {
69 return m_compositingStackingContext; 67 return m_compositingStackingContext;
70 } 68 }
71 69
72 private: 70 private:
73 const PaintLayer* m_compositingStackingContext; 71 const PaintLayer* m_compositingStackingContext;
74 const PaintLayer* m_compositingAncestor; 72 const PaintLayer* m_compositingAncestor;
75 }; 73 };
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 ->assertNeedsToUpdateGraphicsLayerBitsCleared(); 128 ->assertNeedsToUpdateGraphicsLayerBitsCleared();
131 129
132 for (PaintLayer* child = layer.firstChild(); child; 130 for (PaintLayer* child = layer.firstChild(); child;
133 child = child->nextSibling()) 131 child = child->nextSibling())
134 assertNeedsToUpdateGraphicsLayerBitsCleared(*child); 132 assertNeedsToUpdateGraphicsLayerBitsCleared(*child);
135 } 133 }
136 134
137 #endif 135 #endif
138 136
139 } // namespace blink 137 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698