Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2647383004: Float layer should ignore offsets from ancestor inline layers under containing block (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 months ago by Xianzhu
Modified:
9 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Float layer should ignore offsets from ancestor inline layers under containing block - When calculating layer location, we should traverse containers instead of parents, because containers instead of parents affect locations of children. This ensures we get correct location for floating layer. - When calculating layer offset in an ancestor, for a float layer, we should skip inline ancestors below the containing block. BUG=683576 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2647383004 Cr-Commit-Position: refs/heads/master@{#445592} Committed: https://chromium.googlesource.com/chromium/src/+/43437042d29fc936bb50f73cbe29907135936f47

Patch Set 1 #

Patch Set 2 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -9 lines) Patch
A third_party/WebKit/LayoutTests/paint/invalidation/compositing/composited-float-under-composited-inline.html View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/compositing/composited-float-under-composited-inline-expected.html View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/compositing/composited-float-under-composited-inline-expected.txt View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/compositing/stacked-float-under-composited-inline.html View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/compositing/stacked-float-under-composited-inline-expected.html View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/compositing/stacked-float-under-composited-inline-expected.txt View 1 chunk +31 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 2 chunks +22 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerTest.cpp View 1 chunk +65 lines, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 16 (12 generated)
Xianzhu
This CL is kept small to ease merging to M57. https://codereview.chromium.org/2650873002/ is a follow-up to ...
9 months ago (2017-01-23 22:30:35 UTC) #5
chrishtr
lgtm
9 months ago (2017-01-24 00:41:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2647383004/20001
9 months ago (2017-01-24 00:49:39 UTC) #13
commit-bot: I haz the power
9 months ago (2017-01-24 01:57:01 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/43437042d29fc936bb50f73cbe29...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 81bcdb8aa