Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2650853003: Removes a tracing CHECK supposed to investigate infinite SetAutoHideBehavior (Closed)

Created:
3 years, 11 months ago by varkha
Modified:
3 years, 11 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes a tracing CHECK supposed to investigate infinite SetAutoHideBehavior Having the CHECK in stable channel won't give us anything new and it is unfortunately too easy to trigger it (switch profiles repeatedly). Therefore removing the CHECK. This effectively rolls back those 2 changes: https://codereview.chromium.org/2549833002 https://codereview.chromium.org/2562413003 The change will need to be merged in M-56. BUG=665093 Review-Url: https://codereview.chromium.org/2650853003 Cr-Commit-Position: refs/heads/master@{#445567} Committed: https://chromium.googlesource.com/chromium/src/+/1fd4837307a64feabfdb9e2e0d4ba92a40de4738

Patch Set 1 #

Patch Set 2 : Removes a tracing CHECK supposed to investigate infinite SetAutoHideBehavior #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -23 lines) Patch
M ash/common/shelf/wm_shelf.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ash/common/shelf/wm_shelf.cc View 1 2 chunks +1 line, -14 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
varkha
oshima@, can you please take a look? msw@ has a change to possibly address the ...
3 years, 11 months ago (2017-01-23 22:17:01 UTC) #5
oshima
lgtm
3 years, 11 months ago (2017-01-24 00:26:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650853003/20001
3 years, 11 months ago (2017-01-24 00:33:12 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 00:39:37 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1fd4837307a64feabfdb9e2e0d4b...

Powered by Google App Engine
This is Rietveld 408576698