Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2061)

Unified Diff: ash/common/shelf/wm_shelf.cc

Issue 2650853003: Removes a tracing CHECK supposed to investigate infinite SetAutoHideBehavior (Closed)
Patch Set: Removes a tracing CHECK supposed to investigate infinite SetAutoHideBehavior Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/shelf/wm_shelf.h ('k') | ash/shelf/shelf_layout_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/shelf/wm_shelf.cc
diff --git a/ash/common/shelf/wm_shelf.cc b/ash/common/shelf/wm_shelf.cc
index 75bf105b16d6c289849621ce533d11f0d35e9c35..72de8ab0b6881a0695e5444e13adaa419ebd8b68 100644
--- a/ash/common/shelf/wm_shelf.cc
+++ b/ash/common/shelf/wm_shelf.cc
@@ -58,7 +58,7 @@ class WmShelf::AutoHideEventHandler : public ui::EventHandler {
// WmShelf ---------------------------------------------------------------------
-WmShelf::WmShelf() : time_last_auto_hide_change_(base::TimeTicks::Now()) {}
+WmShelf::WmShelf() {}
WmShelf::~WmShelf() {}
@@ -213,19 +213,6 @@ void WmShelf::SetAutoHideBehavior(ShelfAutoHideBehavior auto_hide_behavior) {
if (auto_hide_behavior_ == auto_hide_behavior)
return;
- // Force a stack dump when this method is invoked too frequently.
- // This block is here temporary to help investigate http://crbug.com/665093 .
- constexpr int kAutoHideRepeatInterval = 1000;
- constexpr int kMaxAutoHideChanges = 20;
- if ((base::TimeTicks::Now() - time_last_auto_hide_change_).InMilliseconds() <
- kAutoHideRepeatInterval) {
- if (++count_auto_hide_changes_ > kMaxAutoHideChanges)
- CHECK(false);
- } else {
- count_auto_hide_changes_ = 0;
- }
- time_last_auto_hide_change_ = base::TimeTicks::Now();
-
auto_hide_behavior_ = auto_hide_behavior;
WmShell::Get()->shelf_controller()->NotifyShelfAutoHideBehaviorChanged(this);
WmShell::Get()->NotifyShelfAutoHideBehaviorChanged(
« no previous file with comments | « ash/common/shelf/wm_shelf.h ('k') | ash/shelf/shelf_layout_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698