Adds tracing to investigate infinite calls to SetAutoHideBehavior

Adds tracing to investigate infinite calls to SetAutoHideBehavior

This CL adds a CHECK (a crash with call stack dump) if an infinite loop
calling into WmShelf::SetAutoHideBehavior is detected.

BUG=665093
Committed: https://crrev.com/d1fc7274e74f85dd637d0d2f830d9836973690fa
Cr-Commit-Position: refs/heads/master@{#436405}

[varkha, 2016-12-02 18:39:39]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 18:40:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2016-12-02 18:40:42]

varkha@chromium.org changed reviewers:
+ oshima@chromium.org

[varkha, 2016-12-02 18:40:43]

oshima@, can you please take a look? I am still at loss how this could happen so
adding some forced CHECK.

[commit-bot: I haz the power, 2016-12-02 19:15:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 19:15:39]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-12-05 20:28:54]

lgtm

https://codereview.chromium.org/2549833002/diff/1/ash/common/shelf/wm_shelf.cc
File ash/common/shelf/wm_shelf.cc (right):

https://codereview.chromium.org/2549833002/diff/1/ash/common/shelf/wm_shelf.c...
ash/common/shelf/wm_shelf.cc:172: const int kMaxAutoHideChangesIn10Seconds =
100;
nit: constexpr

[varkha, 2016-12-05 20:41:22]

https://codereview.chromium.org/2549833002/diff/1/ash/common/shelf/wm_shelf.cc
File ash/common/shelf/wm_shelf.cc (right):

https://codereview.chromium.org/2549833002/diff/1/ash/common/shelf/wm_shelf.c...
ash/common/shelf/wm_shelf.cc:172: const int kMaxAutoHideChangesIn10Seconds =
100;
On 2016/12/05 20:28:54, oshima wrote:
> nit: constexpr

Done.

[varkha, 2016-12-05 20:41:32]

The CQ bit was checked by varkha@chromium.org

[varkha, 2016-12-05 20:41:33]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2549833002/#ps20001
(title: "Adds tracing to investigate infinite calls to SetAutoHideBehavior
(nits)")

[commit-bot: I haz the power, 2016-12-05 20:42:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 21:16:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480970492845360,
"parent_rev": "2131c3e87430c1894ffdc1896e70f5e857e67a5e", "commit_rev":
"1f81c6914e6fdca0a24142c41e2455dfd548fd57"}

[commit-bot: I haz the power, 2016-12-05 21:16:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-05 21:21:11]

Description was changed from

==========
Adds tracing to investigate infinite calls to SetAutoHideBehavior

This CL adds a CHECK (a crash with call stack dump) if an infinite loop
calling into WmShelf::SetAutoHideBehavior is detected.

BUG=665093
==========

to

==========
Adds tracing to investigate infinite calls to SetAutoHideBehavior

This CL adds a CHECK (a crash with call stack dump) if an infinite loop
calling into WmShelf::SetAutoHideBehavior is detected.

BUG=665093

Committed: https://crrev.com/d1fc7274e74f85dd637d0d2f830d9836973690fa
Cr-Commit-Position: refs/heads/master@{#436405}
==========

[commit-bot: I haz the power, 2016-12-05 21:21:12]

Patchset 2 (id:??) landed as
https://crrev.com/d1fc7274e74f85dd637d0d2f830d9836973690fa
Cr-Commit-Position: refs/heads/master@{#436405}