Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 2549833002: Adds tracing to investigate infinite calls to SetAutoHideBehavior (Closed)

Created:
4 years ago by varkha
Modified:
4 years ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds tracing to investigate infinite calls to SetAutoHideBehavior This CL adds a CHECK (a crash with call stack dump) if an infinite loop calling into WmShelf::SetAutoHideBehavior is detected. BUG=665093 Committed: https://crrev.com/d1fc7274e74f85dd637d0d2f830d9836973690fa Cr-Commit-Position: refs/heads/master@{#436405}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Adds tracing to investigate infinite calls to SetAutoHideBehavior (nits) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M ash/common/shelf/wm_shelf.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ash/common/shelf/wm_shelf.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
varkha
oshima@, can you please take a look? I am still at loss how this could ...
4 years ago (2016-12-02 18:40:43 UTC) #4
oshima
lgtm https://codereview.chromium.org/2549833002/diff/1/ash/common/shelf/wm_shelf.cc File ash/common/shelf/wm_shelf.cc (right): https://codereview.chromium.org/2549833002/diff/1/ash/common/shelf/wm_shelf.cc#newcode172 ash/common/shelf/wm_shelf.cc:172: const int kMaxAutoHideChangesIn10Seconds = 100; nit: constexpr
4 years ago (2016-12-05 20:28:54 UTC) #7
varkha
https://codereview.chromium.org/2549833002/diff/1/ash/common/shelf/wm_shelf.cc File ash/common/shelf/wm_shelf.cc (right): https://codereview.chromium.org/2549833002/diff/1/ash/common/shelf/wm_shelf.cc#newcode172 ash/common/shelf/wm_shelf.cc:172: const int kMaxAutoHideChangesIn10Seconds = 100; On 2016/12/05 20:28:54, oshima ...
4 years ago (2016-12-05 20:41:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2549833002/20001
4 years ago (2016-12-05 20:42:08 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-05 21:16:57 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-05 21:21:12 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d1fc7274e74f85dd637d0d2f830d9836973690fa
Cr-Commit-Position: refs/heads/master@{#436405}

Powered by Google App Engine
This is Rietveld 408576698