Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Issue 2650643004: [Sync] Make SMTP always have the dump stack function. (Closed)

Created:
3 years, 11 months ago by maxbogue
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Sync] Make SMTP always have the dump stack function. Previously this was threaded through ModelTypeController, which is bad because it meant we uploaded completely useless stacks for any errors in the model code that occurred prior to sync starting up. Now the function is curried directly into the processor factory function, so we always have access to it. BUG=673883, 680093 Review-Url: https://codereview.chromium.org/2639393002 Cr-Commit-Position: refs/heads/master@{#445122} (cherry picked from commit 5f90a97e73ca55f5bbe2fd23fc67da6c3c92010f) Review-Url: https://codereview.chromium.org/2650643004 . Cr-Commit-Position: refs/branch-heads/2987@{#28} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/e696d653aaf7f2797335f773715711270a0b1b0a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -43 lines) Patch
M chrome/browser/sync/test/integration/two_client_uss_sync_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc View 3 chunks +6 lines, -1 line 0 comments Download
M components/browser_sync/profile_sync_components_factory_impl.cc View 5 chunks +8 lines, -13 lines 0 comments Download
M components/browser_sync/profile_sync_service.cc View 1 chunk +3 lines, -1 line 0 comments Download
M components/reading_list/ios/reading_list_model_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M components/sync/driver/data_type_controller.h View 1 chunk +1 line, -4 lines 0 comments Download
M components/sync/driver/data_type_controller.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/sync/driver/directory_data_type_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/sync/driver/directory_data_type_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/sync/driver/model_type_controller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/driver/model_type_controller.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M components/sync/driver/model_type_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/proxy_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/model/model_type_change_processor.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync/model/model_type_change_processor.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/sync/model/model_type_sync_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/model_impl/shared_model_type_processor.h View 2 chunks +8 lines, -1 line 0 comments Download
M components/sync/model_impl/shared_model_type_processor.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M components/sync/model_impl/shared_model_type_processor_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/reading_list/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_model_factory.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
maxbogue
3 years, 11 months ago (2017-01-23 18:23:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e696d653aaf7f2797335f773715711270a0b1b0a.

Powered by Google App Engine
This is Rietveld 408576698