Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1565)

Unified Diff: components/sync/driver/model_type_controller.cc

Issue 2650643004: [Sync] Make SMTP always have the dump stack function. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/driver/model_type_controller.cc
diff --git a/components/sync/driver/model_type_controller.cc b/components/sync/driver/model_type_controller.cc
index b0d28cf087cf72346d312fa894b5625b02ed746e..639d7232d780c71ac630add50b4cb224a2f9c3c0 100644
--- a/components/sync/driver/model_type_controller.cc
+++ b/components/sync/driver/model_type_controller.cc
@@ -62,11 +62,8 @@ void CallGetStatusCountersHelper(
void ReportError(ModelType model_type,
scoped_refptr<base::SingleThreadTaskRunner> ui_thread,
- const base::Closure& dump_stack,
const ModelErrorHandler& error_handler,
const ModelError& error) {
- if (!dump_stack.is_null())
- dump_stack.Run();
UMA_HISTOGRAM_ENUMERATION("Sync.DataTypeRunFailures",
ModelTypeToHistogramInt(model_type),
MODEL_TYPE_COUNT);
@@ -77,10 +74,9 @@ void ReportError(ModelType model_type,
ModelTypeController::ModelTypeController(
ModelType type,
- const base::Closure& dump_stack,
SyncClient* sync_client,
const scoped_refptr<base::SingleThreadTaskRunner>& model_thread)
- : DataTypeController(type, dump_stack),
+ : DataTypeController(type),
sync_client_(sync_client),
model_thread_(model_thread),
sync_prefs_(sync_client->GetPrefService()),
@@ -117,7 +113,7 @@ void ModelTypeController::LoadModels(
base::AsWeakPtr(this)));
ModelErrorHandler error_handler = base::BindRepeating(
- &ReportError, type(), base::ThreadTaskRunnerHandle::Get(), dump_stack_,
+ &ReportError, type(), base::ThreadTaskRunnerHandle::Get(),
base::Bind(&ModelTypeController::ReportModelError,
base::AsWeakPtr(this)));
« no previous file with comments | « components/sync/driver/model_type_controller.h ('k') | components/sync/driver/model_type_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698