[Sync] Make SMTP always have the dump stack function.

[Sync] Make SMTP always have the dump stack function.

Previously this was threaded through ModelTypeController, which is bad
because it meant we uploaded completely useless stacks for any errors
in the model code that occurred prior to sync starting up.

Now the function is curried directly into the processor factory
function, so we always have access to it.

BUG=673883, 680093
Review-Url: https://codereview.chromium.org/2639393002
Cr-Commit-Position: refs/heads/master@{#445122}
Committed: https://chromium.googlesource.com/chromium/src/+/5f90a97e73ca55f5bbe2fd23fc67da6c3c92010f

[maxbogue, 2017-01-18 21:31:01]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 21:32:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 21:35:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 21:35:38]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[maxbogue, 2017-01-19 00:18:22]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 00:18:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 00:24:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 00:24:38]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[maxbogue, 2017-01-19 00:43:50]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 00:44:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 00:52:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 00:52:37]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[maxbogue, 2017-01-19 07:44:29]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 07:44:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 07:50:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 07:50:12]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[maxbogue, 2017-01-19 08:13:50]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 08:14:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 09:46:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 09:46:05]

Dry run: This issue passed the CQ dry run.

[maxbogue, 2017-01-19 16:23:10]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 16:23:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2017-01-19 16:24:07]

maxbogue@chromium.org changed reviewers:
+ skym@chromium.org

[maxbogue, 2017-01-19 16:24:08]

Sky, PTAL! The final part of the error handling revamp.

[commit-bot: I haz the power, 2017-01-19 16:33:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 16:33:14]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[maxbogue, 2017-01-19 16:43:15]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 16:43:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skym, 2017-01-19 17:58:36]

lgtm

https://codereview.chromium.org/2639393002/diff/120001/components/autofill/co...
File components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc
(right):

https://codereview.chromium.org/2639393002/diff/120001/components/autofill/co...
components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc:282:
base::BindRepeating(base::IgnoreResult(&DumpWithoutCrashing)))));
Can you plumb channel through to here and filter out Stable/Beta (but still
leave it at 100%) in either this CL or a follow up? (or make
components/version_info/* provide an accessor which would be the best)

[maxbogue, 2017-01-19 18:03:52]

maxbogue@chromium.org changed reviewers:
+ mathp@chromium.org, olivierrobin@chromium.org

[maxbogue, 2017-01-19 18:03:53]

+olivierrobin for reading_list
+mathp for autofill

PTAL!

[Mathieu, 2017-01-19 18:04:55]

autofill lgtm

[commit-bot: I haz the power, 2017-01-19 18:14:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 18:14:47]

Dry run: This issue passed the CQ dry run.

[maxbogue, 2017-01-19 19:24:54]

Description was changed from

==========
[Sync] Make SMTP always have the dump stack function.

Previously this was threaded through ModelTypeController, which is bad
because it meant we uploaded completely useless stacks for any errors
that occured prior to sync starting up in the model code.

Now the function is curried directly into the processor factory
function, so we always have access to it.

BUG=673883
==========

to

==========
[Sync] Make SMTP always have the dump stack function.

Previously this was threaded through ModelTypeController, which is bad
because it meant we uploaded completely useless stacks for any errors
that occured prior to sync starting up in the model code.

Now the function is curried directly into the processor factory
function, so we always have access to it.

BUG=673883,680093
==========

[maxbogue, 2017-01-19 19:25:10]

Description was changed from

==========
[Sync] Make SMTP always have the dump stack function.

Previously this was threaded through ModelTypeController, which is bad
because it meant we uploaded completely useless stacks for any errors
that occured prior to sync starting up in the model code.

Now the function is curried directly into the processor factory
function, so we always have access to it.

BUG=673883,680093
==========

to

==========
[Sync] Make SMTP always have the dump stack function.

Previously this was threaded through ModelTypeController, which is bad
because it meant we uploaded completely useless stacks for any errors
that occurred prior to sync starting up in the model code.

Now the function is curried directly into the processor factory
function, so we always have access to it.

BUG=673883,680093
==========

[maxbogue, 2017-01-19 19:26:04]

Description was changed from

==========
[Sync] Make SMTP always have the dump stack function.

Previously this was threaded through ModelTypeController, which is bad
because it meant we uploaded completely useless stacks for any errors
that occurred prior to sync starting up in the model code.

Now the function is curried directly into the processor factory
function, so we always have access to it.

BUG=673883,680093
==========

to

==========
[Sync] Make SMTP always have the dump stack function.

Previously this was threaded through ModelTypeController, which is bad
because it meant we uploaded completely useless stacks for any errors
in the model code that occurred prior to sync starting up.

Now the function is curried directly into the processor factory
function, so we always have access to it.

BUG=673883,680093
==========

[Olivier, 2017-01-20 16:17:05]

reading_list LGTM

[maxbogue, 2017-01-20 18:06:43]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2017-01-20 18:07:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 19:18:01]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1484935603254290,
"parent_rev": "e133e5107a17f4bd39425cf0eba036808c21bf20", "commit_rev":
"5f90a97e73ca55f5bbe2fd23fc67da6c3c92010f"}

[commit-bot: I haz the power, 2017-01-20 19:19:42]

Description was changed from

==========
[Sync] Make SMTP always have the dump stack function.

Previously this was threaded through ModelTypeController, which is bad
because it meant we uploaded completely useless stacks for any errors
in the model code that occurred prior to sync starting up.

Now the function is curried directly into the processor factory
function, so we always have access to it.

BUG=673883,680093
==========

to

==========
[Sync] Make SMTP always have the dump stack function.

Previously this was threaded through ModelTypeController, which is bad
because it meant we uploaded completely useless stacks for any errors
in the model code that occurred prior to sync starting up.

Now the function is curried directly into the processor factory
function, so we always have access to it.

BUG=673883,680093

Review-Url: https://codereview.chromium.org/2639393002
Cr-Commit-Position: refs/heads/master@{#445122}
Committed:
https://chromium.googlesource.com/chromium/src/+/5f90a97e73ca55f5bbe2fd23fc67...
==========

[commit-bot: I haz the power, 2017-01-20 19:19:44]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/5f90a97e73ca55f5bbe2fd23fc67...

[maxbogue, 2017-01-20 20:39:47]

https://codereview.chromium.org/2639393002/diff/120001/components/autofill/co...
File components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc
(right):

https://codereview.chromium.org/2639393002/diff/120001/components/autofill/co...
components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc:282:
base::BindRepeating(base::IgnoreResult(&DumpWithoutCrashing)))));
On 2017/01/19 17:58:36, skym wrote:
> Can you plumb channel through to here and filter out Stable/Beta (but still
> leave it at 100%) in either this CL or a follow up? (or make
> components/version_info/* provide an accessor which would be the best)

Whoops, I never responded to this. I've prepared a CL that does this for you to
refer to/patch when it's needed: http://crrev.com/2647113002