DevTools: render console level filter as drop box.

DevTools: render console level filter as drop box.

BUG=682521
NOTRY=true

Review-Url: https://codereview.chromium.org/2650543002
Cr-Commit-Position: refs/heads/master@{#446802}
Committed: https://chromium.googlesource.com/chromium/src/+/2cd38788a3cb6ad017e81d07cbd5788aa6fdce3e

[pfeldman, 2017-01-20 23:07:50]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-01-20 23:07:54]

The CQ bit was unchecked by pfeldman@chromium.org

[pfeldman, 2017-01-20 23:07:59]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[pfeldman, 2017-01-21 00:05:34]

PTAL

[pfeldman1, 2017-01-23 01:46:17]

pfeldman@google.com changed reviewers:
+ pfeldman@google.com

[pfeldman1, 2017-01-23 01:46:17]

PTAL

[lushnikov, 2017-01-23 05:45:36]

lushnikov@chromium.org changed reviewers:
+ lushnikov@chromium.org

[lushnikov, 2017-01-23 05:45:36]

Could you please attach a screenshot?

[pfeldman, 2017-01-23 18:33:47]

On 2017/01/23 05:45:36, lushnikov wrote:
> Could you please attach a screenshot?

it is just a combobox instead of the old bit toggle.

[dgozman, 2017-01-23 18:57:08]

lgtm

https://codereview.chromium.org/2650543002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
(right):

https://codereview.chromium.org/2650543002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:1056:
Common.settings.createSetting('messageLevelFilters2',
SDK.ConsoleMessage.MessageLevel.Info);
2?

https://codereview.chromium.org/2650543002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js (right):

https://codereview.chromium.org/2650543002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js:476:
this._filterComboBox.setSelectedIndex(i);
Select default one when no setting?

https://codereview.chromium.org/2650543002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js:504: var option =
this._options[this._filterComboBox.selectedIndex()];
.value

https://codereview.chromium.org/2650543002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/textPrompt.css (right):

https://codereview.chromium.org/2650543002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/textPrompt.css:7:
.text-prompt-root {
Did you check this doesn't break all other text prompts?

[pfeldman, 2017-01-23 19:37:57]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-01-23 19:37:57]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2650543002/#ps80001
(title: "review comments addressed.")

[commit-bot: I haz the power, 2017-01-23 19:38:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2017-01-23 19:39:17]

The CQ bit was unchecked by pfeldman@chromium.org

[pfeldman, 2017-01-23 19:51:30]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-01-23 19:51:31]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2650543002/#ps100001
(title: "fixed ctrl+p focused")

[commit-bot: I haz the power, 2017-01-23 19:52:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 20:04:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 20:04:51]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[pfeldman, 2017-01-23 20:30:15]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2017-01-23 20:30:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 22:44:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 22:44:43]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pfeldman, 2017-01-26 19:05:00]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-01-26 19:05:00]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2650543002/#ps120001
(title: "rebaselined")

[commit-bot: I haz the power, 2017-01-26 19:05:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 21:00:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 21:00:32]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[pfeldman, 2017-01-26 22:31:41]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-01-26 22:31:41]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2650543002/#ps140001
(title: "for landing")

[commit-bot: I haz the power, 2017-01-26 22:32:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 00:07:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 00:07:28]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[pfeldman1, 2017-01-27 01:43:20]

The CQ bit was checked by pfeldman@google.com

[commit-bot: I haz the power, 2017-01-27 01:44:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 03:36:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 03:36:53]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[pfeldman1, 2017-01-27 05:49:28]

The CQ bit was checked by pfeldman@google.com

[commit-bot: I haz the power, 2017-01-27 05:49:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 07:29:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 07:29:43]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[pfeldman, 2017-01-27 16:26:32]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-01-27 16:26:33]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2650543002/#ps160001
(title: "land already")

[commit-bot: I haz the power, 2017-01-27 16:26:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2017-01-27 19:54:14]

Description was changed from

==========
DevTools: render console level filter as drop box.

BUG=682521
==========

to

==========
DevTools: render console level filter as drop box.

BUG=682521
NOTRY=true
==========

[pfeldman, 2017-01-27 19:54:20]

The CQ bit was unchecked by pfeldman@chromium.org

[pfeldman, 2017-01-27 19:54:29]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2017-01-27 19:55:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 20:05:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 20:05:04]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pfeldman, 2017-01-27 21:34:30]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-01-27 21:34:32]

The CQ bit was unchecked by pfeldman@chromium.org

[pfeldman, 2017-01-27 21:41:30]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-01-27 21:41:30]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2650543002/#ps180001
(title: "rebase again")

[commit-bot: I haz the power, 2017-01-27 21:42:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 22:40:58]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1485553290539520,
"parent_rev": "700d980db862c9780cd20f64a9527ad07687f51b", "commit_rev":
"2cd38788a3cb6ad017e81d07cbd5788aa6fdce3e"}

[commit-bot: I haz the power, 2017-01-27 22:41:36]

Description was changed from

==========
DevTools: render console level filter as drop box.

BUG=682521
NOTRY=true
==========

to

==========
DevTools: render console level filter as drop box.

BUG=682521
NOTRY=true

Review-Url: https://codereview.chromium.org/2650543002
Cr-Commit-Position: refs/heads/master@{#446802}
Committed:
https://chromium.googlesource.com/chromium/src/+/2cd38788a3cb6ad017e81d07cbd5...
==========

[commit-bot: I haz the power, 2017-01-27 22:41:37]

Committed patchset #10 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/2cd38788a3cb6ad017e81d07cbd5...