third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js - Issue 2650543002: DevTools: render console level filter as drop box.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

Issue 2650543002: DevTools: render console level filter as drop box. (Closed)

Patch Set: rebase again Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js ('k') | third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

index b08edf61bb666b263ddd51f6df5fb18a6eb14eae..3cfffb69c3e568d1e340eb4d567ec2ee36a0ae59 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

@@ -965,11 +965,12 @@ Timeline.EventsTimelineTreeView.Filters = class extends Common.Object {

if (!durationMs) {

durationOption.label = Common.UIString('All');

durationOption.title = Common.UIString('Show all records');

+ durationOption.default = true;

} else {

durationOption.label = Common.UIString('\u2265 %dms', durationMs);

durationOption.title = Common.UIString('Hide records shorter than %dms', durationMs);

}

- durationOption.value = durationMs;

+ durationOption.value = String(durationMs);

durationOptions.push(durationOption);

}

var durationFilterUI = new UI.ComboBoxFilterUI(durationOptions);