Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: third_party/WebKit/LayoutTests/inspector/console/console-filter-level-test.html

Issue 2650543002: DevTools: render console level filter as drop box. (Closed)
Patch Set: rebase again Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/console/console-filter-level-test-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/inspector/console/console-filter-level-test.html
diff --git a/third_party/WebKit/LayoutTests/inspector/console/console-filter-level-test.html b/third_party/WebKit/LayoutTests/inspector/console/console-filter-level-test.html
index 52ac076cdf2c572bedc928f7d8496eed854b0da5..e8e07e816bed8bc72db0f16e4209e60c10176a78 100644
--- a/third_party/WebKit/LayoutTests/inspector/console/console-filter-level-test.html
+++ b/third_party/WebKit/LayoutTests/inspector/console/console-filter-level-test.html
@@ -42,38 +42,44 @@ function test()
dumpVisibleMessages();
next();
},
-
- function onlyWarning(next)
+
+ function verbose(next)
{
- Console.ConsoleView.instance()._filter._levelFilterUI._toggleTypeFilter("warning");
+ Common.settings.settingForTest('messageLevelFilters2').set(SDK.ConsoleMessage.MessageLevel.Verbose);
dumpVisibleMessages();
next();
},
- function onlyInfo(next)
+ function info(next)
{
- Console.ConsoleView.instance()._filter._levelFilterUI._toggleTypeFilter("info");
+ Common.settings.settingForTest('messageLevelFilters2').set(SDK.ConsoleMessage.MessageLevel.Info);
dumpVisibleMessages();
next();
},
-
- function onlyErrorDebug(next)
+
+ function warning(next)
{
- Console.ConsoleView.instance()._filter._levelFilterUI._toggleTypeFilter("error");
- Console.ConsoleView.instance()._filter._levelFilterUI._toggleTypeFilter("verbose", true);
+ Common.settings.settingForTest('messageLevelFilters2').set(SDK.ConsoleMessage.MessageLevel.Warning);
dumpVisibleMessages();
next();
},
-
- function onlyAbcMessagePlain(next)
+
+ function error(next)
+ {
+ Common.settings.settingForTest('messageLevelFilters2').set(SDK.ConsoleMessage.MessageLevel.Error);
+ dumpVisibleMessages();
+ next();
+ },
+
+ function abcMessagePlain(next)
{
- Console.ConsoleView.instance()._filter._levelFilterUI._toggleTypeFilter(UI.NamedBitSetFilterUI.ALL_TYPES);
+ Common.settings.settingForTest('messageLevelFilters2').set(SDK.ConsoleMessage.MessageLevel.Verbose);
Console.ConsoleView.instance()._filter._textFilterUI.setValue("abc");
dumpVisibleMessages();
next();
},
- function onlyAbcMessageRegex(next)
+ function abcMessageRegex(next)
{
Console.ConsoleView.instance()._filter._textFilterUI._regexCheckBox.checked = "checked";
Console.ConsoleView.instance()._filter._textFilterUI.setValue("ab[a-z]");
@@ -81,9 +87,9 @@ function test()
next();
},
- function onlyAbcMessageRegexWarning(next)
+ function abcMessageRegexWarning(next)
{
- Console.ConsoleView.instance()._filter._levelFilterUI._toggleTypeFilter("warning", false);
+ Common.settings.settingForTest('messageLevelFilters2').set(SDK.ConsoleMessage.MessageLevel.Warning);
dumpVisibleMessages();
next();
}
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/console/console-filter-level-test-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698