Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2650353002: Revert of Introduce SynchronousMutationObserver::didChangeAttribute() (Closed)

Created:
3 years, 11 months ago by yosin_UTC9
Modified:
3 years, 11 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Introduce SynchronousMutationObserver::didChangeAttribute() (patchset #3 id:60001 of https://codereview.chromium.org/2641803003/ ) Reason for revert: Performance regression on blink_perf.dom: modify-element-title/modify-element-title http://crbug.com/684394 Original issue's description: > Introduce SynchronousMutationObserver::didChangeAttribute() > > This patch introduces |SynchronousMutationObserver::didChangeAttribute()| to > observe attribute changes in |Element| for a preparation of [1] which tracks > attribute changes for invalidating cached |VisibleSelection|. > > [1] http://crrev.com/2637013002: Make FrameSelection to hold non-canonicalized > positions > > BUG=682878 > TEST=run_webkit_unitetests --gtest_filter=DocumentTest.SynchronousMutationNotifierChangeAttribute) > > Review-Url: https://codereview.chromium.org/2641803003 > Cr-Commit-Position: refs/heads/master@{#445006} > Committed: https://chromium.googlesource.com/chromium/src/+/f34f5cb8f4f2f4a54afe4094dc7933193220116e TBR=tkent@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=682878 Review-Url: https://codereview.chromium.org/2650353002 Cr-Commit-Position: refs/heads/master@{#445929} Committed: https://chromium.googlesource.com/chromium/src/+/eb6e1f0d57a18e16ffa21254bf954610112f858b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -44 lines) Patch
M third_party/WebKit/Source/core/dom/DocumentTest.cpp View 6 chunks +0 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/SynchronousMutationNotifier.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/SynchronousMutationNotifier.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/SynchronousMutationObserver.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/SynchronousMutationObserver.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
yosin_UTC9
Created Revert of Introduce SynchronousMutationObserver::didChangeAttribute()
3 years, 11 months ago (2017-01-25 01:30:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650353002/1
3 years, 11 months ago (2017-01-25 01:31:27 UTC) #3
tkent
lgtm
3 years, 11 months ago (2017-01-25 01:37:21 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 03:24:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eb6e1f0d57a18e16ffa21254bf95...

Powered by Google App Engine
This is Rietveld 408576698