Revert of Introduce SynchronousMutationObserver::didChangeAttribute()

third_party/WebKit/Source/core/dom/DocumentTest.cpp

 /*
  * Copyright (c) 2014, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 105 matching lines @@
     DEFINE_INLINE_TRACE() { visitor->trace(m_node); }
   };
 
   TestSynchronousMutationObserver(Document&);
   virtual ~TestSynchronousMutationObserver() = default;
 
   int countContextDestroyedCalled() const {
     return m_contextDestroyedCalledCounter;
   }
 
-  const HeapVector<Member<const Element>>& attributeChangedElements() const {
-    return m_attributeChangedElements;
-  }
-
   const HeapVector<Member<const ContainerNode>>& childrenChangedNodes() const {
     return m_childrenChangedNodes;
   }
 
   const HeapVector<Member<MergeTextNodesRecord>>& mergeTextNodesRecords()
       const {
     return m_mergeTextNodesRecords;
   }
 
   const HeapVector<Member<const Node>>& moveTreeToNewDocumentNodes() const {
@@ skipping 15 matching lines @@
   const HeapVector<Member<UpdateCharacterDataRecord>>&
   updatedCharacterDataRecords() const {
     return m_updatedCharacterDataRecords;
   }
 
   DECLARE_TRACE();
 
  private:
   // Implement |SynchronousMutationObserver| member functions.
   void contextDestroyed(Document*) final;
-  void didChangeAttribute(const Element&) final;
   void didChangeChildren(const ContainerNode&) final;
   void didMergeTextNodes(const Text&, const NodeWithIndex&, unsigned) final;
   void didMoveTreeToNewDocument(const Node& root) final;
   void didSplitTextNode(const Text&) final;
   void didUpdateCharacterData(CharacterData*,
                               unsigned offset,
                               unsigned oldLength,
                               unsigned newLength) final;
   void nodeChildrenWillBeRemoved(ContainerNode&) final;
   void nodeWillBeRemoved(Node&) final;
 
   int m_contextDestroyedCalledCounter = 0;
-  HeapVector<Member<const Element>> m_attributeChangedElements;
   HeapVector<Member<const ContainerNode>> m_childrenChangedNodes;
   HeapVector<Member<MergeTextNodesRecord>> m_mergeTextNodesRecords;
   HeapVector<Member<const Node>> m_moveTreeToNewDocumentNodes;
   HeapVector<Member<ContainerNode>> m_removedChildrenNodes;
   HeapVector<Member<Node>> m_removedNodes;
   HeapVector<Member<const Text>> m_splitTextNodes;
   HeapVector<Member<UpdateCharacterDataRecord>> m_updatedCharacterDataRecords;
 
   DISALLOW_COPY_AND_ASSIGN(TestSynchronousMutationObserver);
 };
 
 TestSynchronousMutationObserver::TestSynchronousMutationObserver(
     Document& document) {
   setContext(&document);
 }
 
 void TestSynchronousMutationObserver::contextDestroyed(Document*) {
   ++m_contextDestroyedCalledCounter;
 }
 
-void TestSynchronousMutationObserver::didChangeAttribute(
-    const Element& element) {
-  m_attributeChangedElements.push_back(&element);
-}
-
 void TestSynchronousMutationObserver::didChangeChildren(
     const ContainerNode& container) {
   m_childrenChangedNodes.push_back(&container);
 }
 
 void TestSynchronousMutationObserver::didMergeTextNodes(
     const Text& node,
     const NodeWithIndex& nodeWithIndex,
     unsigned offset) {
   m_mergeTextNodesRecords.push_back(
@@ skipping 21 matching lines @@
 void TestSynchronousMutationObserver::nodeChildrenWillBeRemoved(
     ContainerNode& container) {
   m_removedChildrenNodes.push_back(&container);
 }
 
 void TestSynchronousMutationObserver::nodeWillBeRemoved(Node& node) {
   m_removedNodes.push_back(&node);
 }
 
 DEFINE_TRACE(TestSynchronousMutationObserver) {
-  visitor->trace(m_attributeChangedElements);
   visitor->trace(m_childrenChangedNodes);
   visitor->trace(m_mergeTextNodesRecords);
   visitor->trace(m_moveTreeToNewDocumentNodes);
   visitor->trace(m_removedChildrenNodes);
   visitor->trace(m_removedNodes);
   visitor->trace(m_splitTextNodes);
   visitor->trace(m_updatedCharacterDataRecords);
   SynchronousMutationObserver::trace(visitor);
 }
 
@@ skipping 254 matching lines @@
   EXPECT_EQ(1u, observer.removedNodes().size())
       << "ContainerNode::removeChildren() doesn't call nodeWillBeRemoved()";
   ASSERT_EQ(1u, observer.removedChildrenNodes().size());
   EXPECT_EQ(divNode, observer.removedChildrenNodes()[0]);
 
   document().shutdown();
   EXPECT_EQ(nullptr, observer.lifecycleContext());
   EXPECT_EQ(1, observer.countContextDestroyedCalled());
 }
 
-TEST_F(DocumentTest, SynchronousMutationNotifierChangeAttribute) {
-  auto& observer = *new TestSynchronousMutationObserver(document());
-  Element* divNode = document().createElement("div");
-  document().body()->appendChild(divNode);
-  divNode->setAttribute(HTMLNames::classAttr, "foo");
-
-  ASSERT_EQ(1u, observer.attributeChangedElements().size());
-  EXPECT_EQ(divNode, observer.attributeChangedElements()[0]);
-
-  divNode->setAttribute(HTMLNames::classAttr, "bar");
-  ASSERT_EQ(2u, observer.attributeChangedElements().size());
-  EXPECT_EQ(divNode, observer.attributeChangedElements()[1]);
-
-  divNode->removeAttribute(HTMLNames::classAttr);
-  ASSERT_EQ(3u, observer.attributeChangedElements().size());
-  EXPECT_EQ(divNode, observer.attributeChangedElements()[2]);
-}
-
 TEST_F(DocumentTest, SynchronousMutationNotifieAppendChild) {
   auto& observer = *new TestSynchronousMutationObserver(document());
   document().body()->appendChild(document().createTextNode("a123456789"));
   ASSERT_EQ(1u, observer.childrenChangedNodes().size());
   EXPECT_EQ(document().body(), observer.childrenChangedNodes()[0]);
 }
 
 TEST_F(DocumentTest, SynchronousMutationNotifieInsertBefore) {
   auto& observer = *new TestSynchronousMutationObserver(document());
   document().documentElement()->insertBefore(
@@ skipping 126 matching lines @@
   {
     setHtmlInnerHTML(
         "<body>"
         "<meta name=\"theme-color\" content=\"#00ff00\">");
     EXPECT_EQ(Color(0, 255, 0), document().themeColor())
         << "Theme color should be bright green.";
   }
 }
 
 }  // namespace blink