Introduce SynchronousMutationObserver::didChangeAttribute()

Introduce SynchronousMutationObserver::didChangeAttribute()

This patch introduces |SynchronousMutationObserver::didChangeAttribute()| to
observe attribute changes in |Element| for a preparation of [1] which tracks
attribute changes for invalidating cached |VisibleSelection|.

[1] http://crrev.com/2637013002: Make FrameSelection to hold non-canonicalized
positions

BUG=682878
TEST=run_webkit_unitetests --gtest_filter=DocumentTest.SynchronousMutationNotifierChangeAttribute)

Review-Url: https://codereview.chromium.org/2641803003
Cr-Commit-Position: refs/heads/master@{#445006}
Committed: https://chromium.googlesource.com/chromium/src/+/f34f5cb8f4f2f4a54afe4094dc7933193220116e

[yosin_UTC9, 2017-01-19 09:22:01]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 09:22:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-01-19 09:23:29]

Description was changed from

==========
2017-01-19T18:18:55

2017-01-19T18:18:14

BUG=
==========

to

==========
Introduce SynchronousMutationObserver::didChangeAttribute()

This patch introduces |SynchronousMutationObserver::didChangeAttribute()| to
observe attribute changes in |Element| for a preparation of [1] which tracks
attribute changes for invalidating cached |VisibleSelection|.

[1] http://crrev.com/2637013002: Make FrameSelection to hold non-canonicalized
positions

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-01-19 09:34:38]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2017-01-19 09:34:39]

PTAL

[commit-bot: I haz the power, 2017-01-19 09:41:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 09:41:57]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[yosin_UTC9, 2017-01-19 22:51:20]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 22:52:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-01-19 23:28:41]

> attribute changes for invalidating cached |VisibleSelection|.

In what case an attribute change affect VisibleSelection?

[yosin_UTC9, 2017-01-19 23:43:26]

Description was changed from

==========
Introduce SynchronousMutationObserver::didChangeAttribute()

This patch introduces |SynchronousMutationObserver::didChangeAttribute()| to
observe attribute changes in |Element| for a preparation of [1] which tracks
attribute changes for invalidating cached |VisibleSelection|.

[1] http://crrev.com/2637013002: Make FrameSelection to hold non-canonicalized
positions

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Introduce SynchronousMutationObserver::didChangeAttribute()

This patch introduces |SynchronousMutationObserver::didChangeAttribute()| to
observe attribute changes in |Element| for a preparation of [1] which tracks
attribute changes for invalidating cached |VisibleSelection|.

[1] http://crrev.com/2637013002: Make FrameSelection to hold non-canonicalized
positions

BUG=682878
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-01-19 23:47:56]

On 2017/01/19 at 23:28:41, tkent wrote:
> > attribute changes for invalidating cached |VisibleSelection|.
> 
> In what case an attribute change affect VisibleSelection?

Changing attribute can change style of elements. 
Hence attribute change can change visible canonicalization.

Examples:
1. Explicit case 1: set "style" to "display:none"
2. Explicit case 2: set "type" to "hidden" on INPUT element
3. Implicit case: set "class" to "uneditable"

P.S.
Add tracking bug number.

[tkent, 2017-01-19 23:51:58]

lgtm.

> TEST=n/a; no behavior changes

This line isn't correct.  This CL contains automated test.

[commit-bot: I haz the power, 2017-01-20 02:11:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 02:11:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yosin_UTC9, 2017-01-20 05:08:09]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-01-20 05:08:09]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2641803003/#ps40001
(title: "2017-01-20T13:51:02 Rebase")

[commit-bot: I haz the power, 2017-01-20 05:08:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 05:23:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 05:23:26]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yosin_UTC9, 2017-01-20 05:34:44]

Patchset #2 (id:20001) has been deleted

[yosin_UTC9, 2017-01-20 05:36:07]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-01-20 05:36:08]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2641803003/#ps60001
(title: "2017-01-20T14:34:58")

[commit-bot: I haz the power, 2017-01-20 05:36:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-01-20 05:37:39]

Description was changed from

==========
Introduce SynchronousMutationObserver::didChangeAttribute()

This patch introduces |SynchronousMutationObserver::didChangeAttribute()| to
observe attribute changes in |Element| for a preparation of [1] which tracks
attribute changes for invalidating cached |VisibleSelection|.

[1] http://crrev.com/2637013002: Make FrameSelection to hold non-canonicalized
positions

BUG=682878
TEST=n/a; no behavior changes
==========

to

==========
Introduce SynchronousMutationObserver::didChangeAttribute()

This patch introduces |SynchronousMutationObserver::didChangeAttribute()| to
observe attribute changes in |Element| for a preparation of [1] which tracks
attribute changes for invalidating cached |VisibleSelection|.

[1] http://crrev.com/2637013002: Make FrameSelection to hold non-canonicalized
positions

BUG=682878
TEST=run_webkit_unitetests
--gtest_filter=DocumentTest.SynchronousMutationNotifierChangeAttribute)
==========

[commit-bot: I haz the power, 2017-01-20 07:16:55]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484890567795740,
"parent_rev": "031fc1e0661a8e3330c5ca3f463f78164cf658a0", "commit_rev":
"f34f5cb8f4f2f4a54afe4094dc7933193220116e"}

[commit-bot: I haz the power, 2017-01-20 07:17:31]

Description was changed from

==========
Introduce SynchronousMutationObserver::didChangeAttribute()

This patch introduces |SynchronousMutationObserver::didChangeAttribute()| to
observe attribute changes in |Element| for a preparation of [1] which tracks
attribute changes for invalidating cached |VisibleSelection|.

[1] http://crrev.com/2637013002: Make FrameSelection to hold non-canonicalized
positions

BUG=682878
TEST=run_webkit_unitetests
--gtest_filter=DocumentTest.SynchronousMutationNotifierChangeAttribute)
==========

to

==========
Introduce SynchronousMutationObserver::didChangeAttribute()

This patch introduces |SynchronousMutationObserver::didChangeAttribute()| to
observe attribute changes in |Element| for a preparation of [1] which tracks
attribute changes for invalidating cached |VisibleSelection|.

[1] http://crrev.com/2637013002: Make FrameSelection to hold non-canonicalized
positions

BUG=682878
TEST=run_webkit_unitetests
--gtest_filter=DocumentTest.SynchronousMutationNotifierChangeAttribute)

Review-Url: https://codereview.chromium.org/2641803003
Cr-Commit-Position: refs/heads/master@{#445006}
Committed:
https://chromium.googlesource.com/chromium/src/+/f34f5cb8f4f2f4a54afe4094dc79...
==========

[commit-bot: I haz the power, 2017-01-20 07:17:32]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f34f5cb8f4f2f4a54afe4094dc79...

[yosin_UTC9, 2017-01-25 01:30:34]

A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/2650353002/ by yosin@chromium.org.

The reason for reverting is: Performance regression on blink_perf.dom:
modify-element-title/modify-element-title

http://crbug.com/684394.