Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(388)

Issue 2650133002: Add TransitionInterpolation class for CSS Transition refactor (Closed)

Created:
1 year, 4 months ago by alancutter (OOO until 2018)
Modified:
1 year, 3 months ago
Reviewers:
Eric Willigers
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add TransitionInterpolation class for CSS Transition refactor This patch is part of refactoring CSS Transitions to use CSSInterpolationTypes instead of AnimatableValues: https://codereview.chromium.org/2680923005 The TransitionInterpolation class is a sibling of InvalidatableInterpolation and does the same thing except it does not need to deal with additive animations, keyframes being invalidated by the environment and needing reconversion of the InterpolationValues. BUG=681424 Review-Url: https://codereview.chromium.org/2650133002 Cr-Commit-Position: refs/heads/master@{#451262} Committed: https://chromium.googlesource.com/chromium/src/+/2457ae9482f7e385d88cad62e066ee9203159d46

Patch Set 1 #

Patch Set 2 : lint #

Messages

Total messages: 13 (8 generated)
Eric Willigers
lgtm
1 year, 3 months ago (2017-01-25 21:47:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650133002/20001
1 year, 3 months ago (2017-02-16 03:39:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/323156)
1 year, 3 months ago (2017-02-16 05:09:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650133002/20001
1 year, 3 months ago (2017-02-17 00:07:32 UTC) #10
commit-bot: I haz the power
1 year, 3 months ago (2017-02-17 07:34:52 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2457ae9482f7e385d88cad62e066...

Powered by Google App Engine
This is Rietveld 408576698